[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12459: [Icon KCM] Port to new design
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-04-26 8:19:01
Message-ID: 20180426081901.1.6B6C0D2C87766BC1 () phabricator ! kde ! org
[Download RAW message or body]

broulik added inline comments.

INLINE COMMENTS

> schwarzer wrote in iconsmodel.cpp:41
> Is this logic the right way around?

The parent is valid for sub levels in a tree but this is a flat model so there will \
never be a parent as we only have a root layer.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12459

To: broulik, #plasma, #vdg
Cc: lueck, schwarzer, hein, zzag, abetts, ngraham, plasma-devel, ragreen, Pitel, \
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12459">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D12459#inline-63886">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">schwarzer</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">iconsmodel.cpp:41</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">Is this logic the right way around?</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">The parent is valid for sub \
levels in a tree but this is a flat model so there will never be a parent as we only \
have a root layer.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12459">https://phabricator.kde.org/D12459</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, VDG<br /><strong>Cc: </strong>lueck, \
schwarzer, hein, zzag, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]