[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9037: use desktop file actions instead of global shortcuts
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-04-24 15:12:32
Message-ID: 20180424151232.1.573CA23E4EFB11E4 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> krunnerglobalshortcuts.cpp:34
> 
> -    migrateEnabledPlugins();
> +    KSharedConfig::Ptr config = KSharedConfig::openConfig("kglobalshortcutsrc");
> +    KConfigGroup runnergroup(config, "krunner");

1. you don't need an exe to do that, this whole thing could have been

File=kglobalshortcutsrc
RemoveGroup=krunner

in the .upd. The syntax allows for quite a lot of manipulation.

2. I did something similar for a powerdevil shortcut migration, it has a huge \
problem.

kconf_update runs, the config updates, kglobalacceld is still running so later syncs \
undoing your script.

Sorry :/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9037

To: mart, #plasma, davidedmundson
Cc: broulik, apol, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson requested changes to this revision.<br \
/>davidedmundson added inline comments.<br />This revision now requires changes to \
proceed. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9037">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D9037#inline-63566">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">krunnerglobalshortcuts.cpp:34</span></div> \
<div style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, \
&quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, \
175, .7);">    <span class="bright"></span><span class="n"><span \
class="bright">migrateEnabledPlugins</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span>);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="bright"></span><span class="n"><span \
class="bright">KSharedConfig</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span class="bright">Ptr</span></span><span \
class="bright"> </span><span class="n"><span class="bright">config</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">=</span></span><span class="bright"> </span><span class="n"><span \
class="bright">KSharedConfig</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">openConfig</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
style="color: #766510"><span \
class="bright">&quot;kglobalshortcutsrc&quot;</span></span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">    <span class="n">KConfigGroup</span> <span class="n">runnergroup</span><span \
class="p">(</span><span class="n">config</span><span class="p">,</span> <span \
style="color: #766510">&quot;krunner&quot;</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><ol \
class="remarkup-list"> <li class="remarkup-list-item">you don&#039;t need an exe to \
do that, this whole thing could have been</li> </ol>

<p style="padding: 0; margin: 8px;">File=kglobalshortcutsrc<br />
RemoveGroup=krunner</p>

<p style="padding: 0; margin: 8px;">in the .upd. The syntax allows for quite a lot of \
manipulation.</p>

<ol class="remarkup-list" start="2">
<li class="remarkup-list-item">I did something similar for a powerdevil shortcut \
migration, it has a huge problem.</li> </ol>

<p style="padding: 0; margin: 8px;">kconf_update runs, the config updates, \
kglobalacceld is still running so later syncs undoing your script.</p>

<p style="padding: 0; margin: 8px;">Sorry :/</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9037">https://phabricator.kde.org/D9037</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma, davidedmundson<br /><strong>Cc: \
</strong>broulik, apol, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]