[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12481: Add dptr to models
From:       Nicolas Fella <noreply () phabricator ! kde ! org>
Date:       2018-04-23 22:00:07
Message-ID: 20180423220007.1.A05C578B88F6722E () phabricator ! kde ! org
[Download RAW message or body]

nicolasfella added inline comments.

INLINE COMMENTS

> broulik wrote in models.h:81
> Why `void*`?

So we can replace it with a "real" private class when we need it without creating a \
empty one now

REPOSITORY
  R994 Pulseaudio Qt Bindings

REVISION DETAIL
  https://phabricator.kde.org/D12481

To: nicolasfella, drosca, apol
Cc: broulik, apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, mart


[Attachment #3 (unknown)]

<table><tr><td style="">nicolasfella added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12481">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D12481#inline-63429">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">models.h:81</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">Why <tt style="background: #ebebeb; font-size: \
13px;">void*</tt>?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">So we can replace it with a &quot;real&quot; private \
class when we need it without creating a empty one \
now</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R994 Pulseaudio Qt \
Bindings</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12481">https://phabricator.kde.org/D12481</a></div></div><br \
/><div><strong>To: </strong>nicolasfella, drosca, apol<br /><strong>Cc: \
</strong>broulik, apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]