[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum w
From:       Scott Harvey <noreply () phabricator ! kde ! org>
Date:       2018-04-17 22:13:37
Message-ID: 20180417221337.1.12CFF0A3001DB466 () phabricator ! kde ! org
[Download RAW message or body]

sharvey added inline comments.

INLINE COMMENTS

> davidedmundson wrote in SettingsBase.cpp:82
> > qreal factor = qBound(1.0, \
> > QGuiApplication::primaryScreen()->devicePixelRatio()/96., 3.0);
> 
> I know you were told to change to this, but don't do that.
> 
> Qt will scale the size you give it here by the devicePixelRatio. This is scaling it \
> twice which we don't want to do. 
> We shouldn't need to be doing any custom high DPI code in window sizing.

So should I just run the "preferred size" (1024x760) through the `boundedTo` function \
for odd-sized screens? In other words, ditch the scale factor completely? As in:

  const QSize screenSize = (QGuiApplication::primaryScreen()->availableSize()*0.9);
  const QSize targetSize = QSize(1024, 700);
  return targetSize.boundedTo(screenSize);

I thought I'd ask before updating the diff for the 19th time.  :-)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart, davidedmundson
Cc: davidedmundson, cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">sharvey added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12252">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D12252#inline-62207">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">davidedmundson</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">SettingsBase.cpp:82</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><blockquote \
style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: \
4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; \
margin: 8px;">qreal factor = qBound(1.0, \
QGuiApplication::primaryScreen()-&gt;devicePixelRatio()/96., 3.0);</p></blockquote>

<p style="padding: 0; margin: 8px;">I know you were told to change to this, but \
don&#039;t do that.</p>

<p style="padding: 0; margin: 8px;">Qt will scale the size you give it here by the \
devicePixelRatio. This is scaling it twice which we don&#039;t want to do.</p>

<p style="padding: 0; margin: 8px;">We shouldn&#039;t need to be doing any custom \
high DPI code in window sizing.</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">So should I just run the &quot;preferred \
size&quot; (1024x760) through the <tt style="background: #ebebeb; font-size: \
13px;">boundedTo</tt> function for odd-sized screens? In other words, ditch the scale \
factor completely? As in:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">const QSize screenSize = \
(QGuiApplication::primaryScreen()-&gt;availableSize()*0.9); const QSize targetSize = \
QSize(1024, 700); return targetSize.boundedTo(screenSize);</pre></div>

<p style="padding: 0; margin: 8px;">I thought I&#039;d ask before updating the diff \
for the 19th time.  :-)</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R124 System Settings</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12252">https://phabricator.kde.org/D12252</a></div></div><br \
/><div><strong>To: </strong>sharvey, ngraham, mart, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]