[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum w
From: Vlad Zagorodniy <noreply () phabricator ! kde ! org>
Date: 2018-04-16 23:31:06
Message-ID: 20180416233106.1.77C3E4B8B8885A85 () phabricator ! kde ! org
[Download RAW message or body]
zzag added inline comments.
INLINE COMMENTS
> SettingsBase.cpp:82
> + // calculate base window size to an appropriate size
> + qreal factor = QGuiApplication::primaryScreen()->devicePixelRatio();
> + return QSize(1024*factor, 768*factor);
You forgot `const`.
Also, you could multiply whole QSize by `factor` so Qt will round width and height. \
;-)
REPOSITORY
R124 System Settings
BRANCH
enlarge-default-size (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D12252
To: sharvey, ngraham, mart
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12252">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D12252#inline-62020">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">SettingsBase.cpp:82</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span \
class="bright"></span><span class="n"><span class="bright">qreal</span></span><span \
class="bright"> </span><span class="n"><span class="bright">factor</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">=</span></span><span class="bright"> </span><span class="n"><span \
class="bright">qBound</span></span><span class="bright"></span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span style="color: \
#601200"><span class="bright">1.</span></span><span class="bright"></span><span \
class="p"><span class="bright">,</span></span><span class="bright"> </span><span \
class="n"><span class="bright">QGuiApplication</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">::</span></span><span class="bright"></span><span class="n"><span \
class="bright">primaryScreen</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">-></span></span><span \
class="bright"></span><span class="n"><span \
class="bright">physicalDotsPerInch</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">/</span></span><span \
class="bright"></span><span style="color: #601200"><span \
class="bright">96.</span></span><span class="bright"></span><span class="p"><span \
class="bright">,</span></span><span class="bright"> </span><span style="color: \
#601200"><span class="bright">3.</span></span><span class="bright"></span><span \
class="p"><span class="bright">);</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);"> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: \
#aa4000">return</span> <span style="color: #004012">QSize</span><span \
class="p">(<span class="bright"></span></span><span class="bright"></span><span \
style="color: #601200"><span class="bright">720</span></span><span style="color: \
#aa2211">*</span><span class="n">factor</span><span class="p">,</span> <span \
class="bright"></span><span style="color: #601200"><span \
class="bright">600</span></span><span style="color: #aa2211">*</span><span \
class="n">factor</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="bright"></span><span style="color: #74777d"><span class="bright">// calculate \
base window size to an appropriate size</span></span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"> \
</span><span class="n"><span class="bright">qreal</span></span><span class="bright"> \
</span><span class="n"><span class="bright">factor</span></span><span class="bright"> \
</span><span style="color: #aa2211"><span class="bright">=</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">QGuiApplication</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">primaryScreen</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">-></span></span><span \
class="bright"></span><span class="n"><span \
class="bright">devicePixelRatio</span></span><span class="bright"></span><span \
class="p"><span class="bright">();</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">return</span> <span style="color: #004012">QSize</span><span \
class="p">(<span class="bright"></span></span><span class="bright"></span><span \
style="color: #601200"><span class="bright">1024</span></span><span style="color: \
#aa2211">*</span><span class="n">factor</span><span class="p">,</span> <span \
class="bright"></span><span style="color: #601200"><span \
class="bright">768</span></span><span style="color: #aa2211">*</span><span \
class="n">factor</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You \
forgot <tt style="background: #ebebeb; font-size: 13px;">const</tt>.</p>
<p style="padding: 0; margin: 8px;">Also, you could multiply whole QSize by <tt \
style="background: #ebebeb; font-size: 13px;">factor</tt> so Qt will round width and \
height. ;-)</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R124 System Settings</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>enlarge-default-size (branched from \
master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12252">https://phabricator.kde.org/D12252</a></div></div><br \
/><div><strong>To: </strong>sharvey, ngraham, mart<br /><strong>Cc: </strong>zzag, \
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic