[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11198: [libbreezecommon] add box shadow helper
From:       Vlad Zagorodniy <noreply () phabricator ! kde ! org>
Date:       2018-04-11 0:10:47
Message-ID: 20180411001047.1.5C8AC3B41D7B9D6A () phabricator ! kde ! org
[Download RAW message or body]

zzag updated this revision to Diff 31846.
zzag added a comment.


  Because this patch hasn't been landed yet, I would like to post here
  my recent work on optimizing the box shadow helper...
  
  Summary of changes:
  
  - re-write naive blur helper
  - modify only alpha channel in blur helpers
  - reserve memory for kernel in computeGaussianKernel
  
  See, benchmark results \
https://docs.google.com/spreadsheets/d/1ykAUyspF6BgCFb_U7-muLDEYzrOTNiT5CvFgqCU2xTs/edit?usp=sharing


REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11198?vs=31808&id=31846

BRANCH
  refine-shadows-libbreezecommon

REVISION DETAIL
  https://phabricator.kde.org/D11198

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  kstyle/CMakeLists.txt
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp
  libbreezecommon/breezeboxshadowhelper.h
  libbreezecommon/config-breezecommon.h.cmake

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">zzag updated this revision to Diff 31846.<br />zzag added a \
comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11198">View Revision</a></tr></table><br \
/><div><div><p>Because this patch hasn&#039;t been landed yet, I would like to post \
here<br /> my recent work on optimizing the box shadow helper...</p>

<p>Summary of changes:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">re-write naive blur helper</li>
<li class="remarkup-list-item">modify only alpha channel in blur helpers</li>
<li class="remarkup-list-item">reserve memory for kernel in \
computeGaussianKernel</li> </ul>

<p>See, benchmark results <a \
href="https://docs.google.com/spreadsheets/d/1ykAUyspF6BgCFb_U7-muLDEYzrOTNiT5CvFgqCU2xTs/edit?usp=sharing" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://docs.google.com/spreadsheets/d/1ykAUyspF6BgCFb_U7-muLDEYzrOTNiT5CvFgqCU2xTs/edit?usp=sharing</a></p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D11198?vs=31808&amp;id=31846">https://phabricator.kde.org/D11198?vs=31808&amp;id=31846</a></div></div><br \
/><div><strong>BRANCH</strong><div><div>refine-shadows-libbreezecommon</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11198">https://phabricator.kde.org/D11198</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br /> \
cmake/Modules/FindFFTW.cmake<br /> kstyle/CMakeLists.txt<br />
libbreezecommon/CMakeLists.txt<br />
libbreezecommon/breezeboxshadowhelper.cpp<br />
libbreezecommon/breezeboxshadowhelper.h<br />
libbreezecommon/config-breezecommon.h.cmake</div></div></div><br /><div><strong>To: \
</strong>zzag, Breeze, VDG, hpereiradacosta<br /><strong>Cc: </strong>broulik, \
abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]