[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11533: [kstyle] create shadow tiles more explicitly
From:       Hugo Pereira Da Costa <noreply () phabricator ! kde ! org>
Date:       2018-04-09 16:36:32
Message-ID: 20180409163632.1.67DD717244502483 () phabricator ! kde ! org
[Download RAW message or body]

hpereiradacosta added a comment.


  Hi Vlad,
  
  First sorry for the late answer !
  Second: I agree that the current code is bug prone, but your foreseen change is not \
satisfactory either.   The idea with the current code was to try create the shadows \
only "once" and if it fails for some reason, leave it failed for all widgets for \
which it is requested.   In your modified code however, if the creation of \
shadowtiles fails once, it keeps being called over and over again for each new \
widget.   I think this should be avoided. 
  One solution is possibly to call shadowTiles once and only once, in \
breezeStyle::loadConfiguration, and just test whether it is valid whenever used.   \
what do you think ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11533

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">hpereiradacosta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11533">View Revision</a></tr></table><br \
/><div><div><p>Hi Vlad,</p>

<p>First sorry for the late answer !<br />
Second: I agree that the current code is bug prone, but your foreseen change is not \
satisfactory either. <br /> The idea with the current code was to try create the \
shadows only &quot;once&quot; and if it fails for some reason, leave it failed for \
all widgets for which it is requested. <br /> In your modified code however, if the \
creation of shadowtiles fails once, it keeps being called over and over again for \
each new widget. <br /> I think this should be avoided. <br />
One solution is possibly to call shadowTiles once and only once, in \
breezeStyle::loadConfiguration, and just test whether it is valid whenever used. <br \
/> what do you think ?</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11533">https://phabricator.kde.org/D11533</a></div></div><br \
/><div><strong>To: </strong>zzag, Breeze, hpereiradacosta<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]