[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6183: [Digital Clock] Allow copying current date and time to clipboard
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-04-06 8:33:40
Message-ID: 20180406083340.1.D17D95CF5955E1C6 () phabricator ! kde ! org
[Download RAW message or body]

broulik added a comment.


  Looks good
  
  >   I don't know how to make the result of the action available to the MMB (middle \
mouse button).  
  `QClipboard::setText()` has a `mode` argument that specifies which buffer it should \
use.  Default is `QClipboard::Clipboard` (the Ctrl+V one), just call it again with \
`QClipboard::Selection` for middle mouse paste

INLINE COMMENTS

> broulik wrote in DigitalClock.qml:74
> I just figured since `ClipboardMenu` is a singleton-type, it's shared between all \
> digital clock applets. You can have different timezones in each. So what we instead \
> should do is: 
> Connections {
> target: plasmoid
> onContextualActionsAboutToShow: {
> ClipboardMenu.currentDate = main.currentTime;
> }
> }
> 
> This way we always only update when the respective context menu is opened.

You didn't address this comment in your updated patch

REVISION DETAIL
  https://phabricator.kde.org/D6183

To: bschiffner, #plasma, broulik
Cc: sharvey, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6183">View Revision</a></tr></table><br \
/><div><div><p>Looks good</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><div \
class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">I don&#039;t know how to make \
the result of the action available to the MMB (middle mouse \
button).</pre></div></blockquote>

<p><tt style="background: #ebebeb; font-size: 13px;">QClipboard::setText()</tt> has a \
<tt style="background: #ebebeb; font-size: 13px;">mode</tt> argument that specifies \
which buffer it should use.<br /> Default is <tt style="background: #ebebeb; \
font-size: 13px;">QClipboard::Clipboard</tt> (the Ctrl+V one), just call it again \
with <tt style="background: #ebebeb; font-size: 13px;">QClipboard::Selection</tt> for \
middle mouse paste</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D6183#inline-31191">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">DigitalClock.qml:74</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">I just figured since <tt style="background: #ebebeb; font-size: \
13px;">ClipboardMenu</tt> is a singleton-type, it&#039;s shared between all digital \
clock applets. You can have different timezones in each. So what we instead should do \
is:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Connections {  target: \
plasmoid  onContextualActionsAboutToShow: {
        ClipboardMenu.currentDate = main.currentTime;
    }
}</pre></div>

<p style="padding: 0; margin: 8px;">This way we always only update when the \
respective context menu is opened.</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">You didn&#039;t address this \
comment in your updated patch</p></div></div></div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6183">https://phabricator.kde.org/D6183</a></div></div><br \
/><div><strong>To: </strong>bschiffner, Plasma, broulik<br /><strong>Cc: \
</strong>sharvey, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]