[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11909: properly use kpackage_install_package
From:       Vlad Zagorodniy <noreply () phabricator ! kde ! org>
Date:       2018-04-03 21:10:20
Message-ID: 20180403211020.1.ABF3A239B54EAEB6 () phabricator ! kde ! org
[Download RAW message or body]

zzag added a subscriber: davidedmundson.
zzag added a comment.


  @davidedmundson in \
https://github.com/KDE/plasma-workspace/commit/450ef5884d9e93e6f0a2df48aae82f9ed239b394 \
you said:  
  > Concept is fine, but currently we have severe CMake issues ...
  
  I've tried `kpackage_install_bundled_package` and it works pretty fine. Or am I \
missing something? (CMake version: 3.10.3)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11909

To: zzag, #breeze
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">zzag added a subscriber: davidedmundson.<br />zzag added a \
comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11909">View Revision</a></tr></table><br \
/><div><div><p><a href="https://phabricator.kde.org/p/davidedmundson/" style="  \
border-color: #f1f7ff;  color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@davidedmundson</a> in <a \
href="https://github.com/KDE/plasma-workspace/commit/450ef5884d9e93e6f0a2df48aae82f9ed239b394" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://github.com/KDE/plasma-workspace/commit/450ef5884d9e93e6f0a2df48aae82f9ed239b394</a> \
you said:</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>Concept is fine, but currently we have severe CMake issues \
...</p></blockquote>

<p>I&#039;ve tried <tt style="background: #ebebeb; font-size: \
13px;">kpackage_install_bundled_package</tt> and it works pretty fine. Or am I \
missing something? (CMake version: 3.10.3)</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11909">https://phabricator.kde.org/D11909</a></div></div><br \
/><div><strong>To: </strong>zzag, Breeze<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]