[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D11849: [kdecoration] properly compare opacity values
From: Vlad Zagorodniy <noreply () phabricator ! kde ! org>
Date: 2018-04-03 1:17:34
Message-ID: 20180403011734.1.D9507A81D625D390 () phabricator ! kde ! org
[Download RAW message or body]
zzag abandoned this revision.
zzag added a comment.
In D11849#238798 <https://phabricator.kde.org/D11849#238798>, @davidedmundson \
wrote:
> Whilst qFuzzyCompare is indeed needed for comparing a calculation with a value, \
it's not relevant in all cases, like this. >
> We want setOpacity(actually zero) to update m_opacity over \
setOpacity(something near zero) as it hypothetically changes QPainter paths which \
check for actual zero.
Oh, I see.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D11849
To: zzag, #breeze, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">zzag abandoned this revision.<br />zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11849">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D11849#238798" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D11849#238798</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Whilst qFuzzyCompare is indeed needed for \
comparing a calculation with a value, it's not relevant in all cases, like \
this.</p>
<p>We want setOpacity(actually zero) to update m_opacity over \
setOpacity(something near zero) as it hypothetically changes QPainter paths which \
check for actual zero.</p></div> </blockquote>
<p>Oh, I see.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 \
Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11849">https://phabricator.kde.org/D11849</a></div></div><br \
/><div><strong>To: </strong>zzag, Breeze, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic