[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11842: Remove categories from app delegates
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-03-31 18:45:52
Message-ID: 20180331184552.1.E447A44006E35BE4 () phabricator ! kde ! org
[Download RAW message or body]

ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch removes category labels from the app delegates, for the following \
reasons:  
  - They're not very useful in the first place; the caption generally provides all \
                the information you need without click on it for a more detailed view
  - They clutter up the presentation and make it harder to parse quickly
  - For certain apps and certain views, they sometimes don't show up at all, which is \
confusing and inconsistent

TEST PLAN
  Looks better:
  [images go here]

REPOSITORY
  R134 Discover Software Store

BRANCH
  remove-categories-on-delegates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11842

AFFECTED FILES
  discover/qml/ApplicationDelegate.qml

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">ngraham created this revision.<br />ngraham added reviewers: \
apol, Discover Software Store.<br />Restricted Application added a project: \
Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />ngraham \
requested review of this revision. </td><a style="text-decoration: none; padding: 4px \
8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11842">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>This patch removes category labels \
from the app delegates, for the following reasons:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">They&#039;re not very useful in the first place; the \
caption generally provides all the information you need without click on it for a \
more detailed view</li> <li class="remarkup-list-item">They clutter up the \
presentation and make it harder to parse quickly</li> <li \
class="remarkup-list-item">For certain apps and certain views, they sometimes \
don&#039;t show up at all, which is confusing and inconsistent</li> \
</ul></div></div><br /><div><strong>TEST PLAN</strong><div><p>Looks better:<br /> \
[images go here]</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R134 \
Discover Software Store</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>remove-categories-on-delegates (branched from \
master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11842">https://phabricator.kde.org/D11842</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>discover/qml/ApplicationDelegate.qml</div></div></div><br \
/><div><strong>To: </strong>ngraham, apol, Discover Software Store<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]