[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11262: KDE logout screen background color fix
From:       Christoph Feck <noreply () phabricator ! kde ! org>
Date:       2018-03-30 20:54:52
Message-ID: 20180330205452.1.BE2C345ECFBE4243 () phabricator ! kde ! org
[Download RAW message or body]

cfeck added a comment.


  In D11262#237017 <https://phabricator.kde.org/D11262#237017>, @Pitel wrote:
  
  > I guess I should have renamed it from `isLightColor` to something like \
`isNotAlmostBlack`... The point was to replace almost black colors with real black \
because it looks better with opacity. IMHO `(0,0,128)`, which is deep blue, is far \
enough from black to not mess with it because font colors readable on deep blue \
background might not be readable on black one.  
  
  Ah okey. I had the impression this was used to decide if light or dark text needs \
to be used. I wouldn't want to see black text on dark blue buttons :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: ragreen, fvogt, cfeck, fredrik, ngraham, abetts, broulik, mvourlakos, \
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">cfeck added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11262">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D11262#237017" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D11262#237017</a>, <a \
href="https://phabricator.kde.org/p/Pitel/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@Pitel</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I guess I should have renamed it from <tt \
style="background: #ebebeb; font-size: 13px;">isLightColor</tt> to something like <tt \
style="background: #ebebeb; font-size: 13px;">isNotAlmostBlack</tt>... The point was \
to replace almost black colors with real black because it looks better with opacity. \
IMHO <tt style="background: #ebebeb; font-size: 13px;">(0,0,128)</tt>, which is deep \
blue, is far enough from black to not mess with it because font colors readable on \
deep blue background might not be readable on black one.</p></div> </blockquote>

<p>Ah okey. I had the impression this was used to decide if light or dark text needs \
to be used. I wouldn&#039;t want to see black text on dark blue buttons \
:)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11262">https://phabricator.kde.org/D11262</a></div></div><br \
/><div><strong>To: </strong>Pitel, mart, Plasma<br /><strong>Cc: </strong>ragreen, \
fvogt, cfeck, fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]