[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11262: KDE logout screen background color fix
From:       Christoph Feck <noreply () phabricator ! kde ! org>
Date:       2018-03-30 13:48:39
Message-ID: 20180330134839.1.4596CB41420057CC () phabricator ! kde ! org
[Download RAW message or body]

cfeck added a comment.


  In D11262#235414 <https://phabricator.kde.org/D11262#235414>, @Pitel wrote:
  
  > I finally got to do some testing and it is not looking good for luminance formula \
`0.2126*r + 0.7152*g + 0.0722*b`.  >
  > Screenshot with background color `#5500FF` (blueish, button background on \
picture), you can see that black text is readable on it, but it has luminance only \
0.14 so in overlay it is replaced by black.  >  F5769603: \
Screenshot_20180327_174715.png <https://phabricator.kde.org/F5769603>  >
  > So I would rather stay conservative, and used formula `max(r, g, b)`. I am still \
not sure whether the threshold should be `0.5` or a bit lower...  
  
  You can adjust the coefficients. Please check color (0, 0, 128), which is - \
according to the committed way - considered a light color.  
  Maybe try something like (r+2*g+b) > 0.8.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: cfeck, fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ragreen, \
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">cfeck added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11262">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D11262#235414" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D11262#235414</a>, <a \
href="https://phabricator.kde.org/p/Pitel/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@Pitel</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I finally got to do some testing and it is \
not looking good for luminance formula <tt style="background: #ebebeb; font-size: \
13px;">0.2126*r + 0.7152*g + 0.0722*b</tt>.</p>

<p>Screenshot with background color <tt style="background: #ebebeb; font-size: \
13px;">#5500FF</tt> (blueish, button background on picture), you can see that black \
text is readable on it, but it has luminance only 0.14 so in overlay it is replaced \
by black.<br />  <a href="https://phabricator.kde.org/F5769603" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F5769603: \
Screenshot_20180327_174715.png</a></p>

<p>So I would rather stay conservative, and used formula <tt style="background: \
#ebebeb; font-size: 13px;">max(r, g, b)</tt>. I am still not sure whether the \
threshold should be <tt style="background: #ebebeb; font-size: 13px;">0.5</tt> or a \
bit lower...</p></div> </blockquote>

<p>You can adjust the coefficients. Please check color (0, 0, 128), which is - \
according to the committed way - considered a light color.</p>

<p>Maybe try something like (r+2*g+b) &gt; 0.8.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11262">https://phabricator.kde.org/D11262</a></div></div><br \
/><div><strong>To: </strong>Pitel, mart, Plasma<br /><strong>Cc: </strong>cfeck, \
fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ragreen, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]