[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D11410: [RFC] Add option to make applet fixed width
From: Marco Martin <noreply () phabricator ! kde ! org>
Date: 2018-03-30 11:29:16
Message-ID: 20180330112916.1.D9F01D3A9CF3651B () phabricator ! kde ! org
[Download RAW message or body]
mart added a comment.
almost there :)
I have a couple of points, then it can go :)
INLINE COMMENTS
> ConfigOverlay.qml:385
> + iconSource: "distribute-horizontal-x"
> + visible: currentApplet.expandingApplet
> + tooltip: i18n("Make applet non-expanding size")
this will probably need as well
currentApplet.applet.pluginName == "org.kde.plasma.panelspacer"
or it gets lost when the spacer is configured as not expanding and i guess the spacer \
is special and we want this option to be always there (step 2 would be removing the \
option in the spacer and make it use this system, but it's for a next commit)
> ConfigOverlay.qml:402
> + }
> + var tmp = plasmoid.configuration.fixedSizeOverride
> + var index = tmp.indexOf(currentApplet.applet.id)
is it necessary to use a temp copy?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D11410
To: Pitel, #plasma
Cc: mart, hein, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol
[Attachment #3 (unknown)]
<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11410">View Revision</a></tr></table><br \
/><div><div><p>almost there :)<br /> I have a couple of points, then it can go \
:)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: \
6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div \
style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; \
border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; \
padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D11410#inline-58865">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ConfigOverlay.qml:385</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #aa4000">iconSource:</span> <span style="color: \
#766510">"distribute-horizontal-x"</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">visible:</span> <span style="color: \
#004012">currentApplet</span><span class="p">.</span><span style="color: \
#004012">expandingApplet</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">tooltip:</span> <span style="color: #004012">i18n</span><span \
class="p">(</span><span style="color: #766510">"Make applet non-expanding \
size"</span><span class="p">)</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this \
will probably need as well<br /> currentApplet.applet.pluginName == \
"org.kde.plasma.panelspacer"</p>
<p style="padding: 0; margin: 8px;">or it gets lost when the spacer is configured as \
not expanding and i guess the spacer is special and we want this option to be always \
there<br /> (step 2 would be removing the option in the spacer and make it use this \
system, but it's for a next commit)</p></div></div><br /><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D11410#inline-58866">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ConfigOverlay.qml:402</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="p">}</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">var</span> <span style="color: #004012">tmp</span> <span style="color: \
#aa2211">=</span> <span style="color: #004012">plasmoid</span><span \
class="p">.</span><span style="color: #004012">configuration</span><span \
class="p">.</span><span style="color: #004012">fixedSizeOverride</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #aa4000">var</span> <span style="color: #004012">index</span> \
<span style="color: #aa2211">=</span> <span style="color: #004012">tmp</span><span \
class="p">.</span><span style="color: #004012">indexOf</span><span \
class="p">(</span><span style="color: #004012">currentApplet</span><span \
class="p">.</span><span style="color: #004012">applet</span><span \
class="p">.</span><span style="color: #004012">id</span><span class="p">)</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">is it necessary to use a temp \
copy?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11410">https://phabricator.kde.org/D11410</a></div></div><br \
/><div><strong>To: </strong>Pitel, Plasma<br /><strong>Cc: </strong>mart, hein, \
plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic