[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11757: Polish sidebar header appearance
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-03-28 18:27:26
Message-ID: 20180328182726.1.D543BFE10A65F011 () phabricator ! kde ! org
[Download RAW message or body]

ngraham added a comment.


  In D11757#236015 <https://phabricator.kde.org/D11757#236015>, @richardbowen wrote:
  
  > The greyborder around the submenu heading isn't consistent with the other main \
menu heading which have no border, and inconsistent with the Kirigami back button \
style but otherwise, it looks good.  
  
  Kirigami has multiple columnar navigation paradigms. The one whose visual style I'm \
emulating is the `ToolbarApplicationHeader`, which has gray toolbar-style backgrounds \
for the headers. System Settings previously had inconsistent approach: using the \
`ToolbarApplicationHeader` style for the main category list, but not the subcategory \
list. I think using the `ToolbarApplicationHeader` style for both looks better, and \
is a superior option to abandoning it for both, which presents issues for the header \
on the main category list given that it's always going to be scrollable.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D11757

To: ngraham, mart, #plasma, #vdg
Cc: davidedmundson, abetts, richardbowen, plasma-devel, ragreen, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11757">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D11757#236015" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D11757#236015</a>, <a \
href="https://phabricator.kde.org/p/richardbowen/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@richardbowen</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>The greyborder around the submenu heading \
isn&#039;t consistent with the other main menu heading which have no border, and \
inconsistent with the Kirigami back button style but otherwise, it looks \
good.</p></div> </blockquote>

<p>Kirigami has multiple columnar navigation paradigms. The one whose visual style \
I&#039;m emulating is the <tt style="background: #ebebeb; font-size: \
13px;">ToolbarApplicationHeader</tt>, which has gray toolbar-style backgrounds for \
the headers. System Settings previously had inconsistent approach: using the <tt \
style="background: #ebebeb; font-size: 13px;">ToolbarApplicationHeader</tt> style for \
the main category list, but not the subcategory list. I think using the <tt \
style="background: #ebebeb; font-size: 13px;">ToolbarApplicationHeader</tt> style for \
both looks better, and is a superior option to abandoning it for both, which presents \
issues for the header on the main category list given that it&#039;s always going to \
be scrollable.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R124 \
System Settings</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11757">https://phabricator.kde.org/D11757</a></div></div><br \
/><div><strong>To: </strong>ngraham, mart, Plasma, VDG<br /><strong>Cc: \
</strong>davidedmundson, abetts, richardbowen, plasma-devel, ragreen, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]