[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2018-03-26 13:41:07
Message-ID: 20180326134107.1.B7371FB9DBDC8D35 () phabricator ! kde ! org
[Download RAW message or body]
davidedmundson added inline comments.
INLINE COMMENTS
> libinput_settings.cpp:26
> +{
> + KConfig config("kcminputrc");
> + KConfigGroup group = config.group("Mouse");
KConfig("foo")
will load foo and parse it every time.
> libinput_settings.h:27
> + template<class T>
> + T load(QString key, T defVal);
>
this use of templates doesn't match the implementation
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D11469
To: romangg, #plasma
Cc: davidedmundson, hein, mart, abetts, ngraham, plasma-devel, ragreen, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol
[Attachment #3 (unknown)]
<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11469">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D11469#inline-58106">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">libinput_settings.cpp:26</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">KConfig</span> <span \
class="n">config</span><span class="p">(</span><span style="color: \
#766510">"kcminputrc"</span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">KConfigGroup</span> <span class="n">group</span> <span style="color: \
#aa2211">=</span> <span class="n">config</span><span class="p">.</span><span \
class="n">group</span><span class="p">(</span><span style="color: \
#766510">"Mouse"</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">KConfig("foo")<br /> will load foo and parse it every \
time.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D11469#inline-58107">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">libinput_settings.h:27</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span \
class="bright"></span><span style="color: #aa4000"><span \
class="bright">void</span></span><span class="bright"> </span><span class="n"><span \
class="bright">save</span></span><span class="bright"></span><span class="p"><span \
class="bright">();</span></span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span \
style="color: #aa4000"><span class="bright">void</span></span> <span style="color: \
#004012">load</span><span class="p">(<span class="bright"></span></span><span \
class="bright"></span><span class="n"><span \
class="bright">X11Backend</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">*</span></span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);"> <span style="color: #aa4000">void</span> <span style="color: \
#004012">apply</span><span class="p">(</span><span class="n">X11Backend</span> <span \
style="color: #aa2211">*</span><span class="p">,</span> <span style="color: \
#aa4000">bool</span> <span class="n">force</span> <span style="color: \
#aa2211">=</span> <span style="color: #304a96">false</span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="bright"></span><span class="n"><span \
class="bright">template</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright"><</span></span><span class="bright"></span><span \
class="n"><span class="bright">class</span></span><span class="bright"> </span><span \
class="n"><span class="bright">T</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">></span></span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="bright"></span><span class="n"><span class="bright">T</span></span> <span \
class="n">load</span><span class="p">(<span class="bright"></span></span><span \
class="bright"></span><span class="n"><span class="bright">QString</span></span><span \
class="bright"> </span><span class="n"><span class="bright">key</span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span \
class="bright"> </span><span class="n"><span class="bright">T</span></span><span \
class="bright"> </span><span class="n"><span class="bright">defVal</span></span><span \
class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this \
use of templates doesn't match the \
implementation</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11469">https://phabricator.kde.org/D11469</a></div></div><br \
/><div><strong>To: </strong>romangg, Plasma<br /><strong>Cc: </strong>davidedmundson, \
hein, mart, abetts, ngraham, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, sebas, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic