[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D1230: GBM remote access support for KWin
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2018-03-25 17:05:06
Message-ID: 20180325170506.1.D90D8EF7E4038E9A () phabricator ! kde ! org
[Download RAW message or body]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Looks fine to me. Tested runtime together with your KWayland patch.
  
  Probably you know this, but please push as one commit only to master.

INLINE COMMENTS

> egl_gbm_backend.cpp:160
> +{
> +    if (qEnvironmentVariableIsSet("KWIN_NO_REMOTE"))
> +        return;

Use braces: https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces

REPOSITORY
  R108 KWin

BRANCH
  fix-clang

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, \
davidedmundson, plasma-devel, ragreen, schernikov, iodelay, zzag, bwowk, ZrenBot, \
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, \
mart, hein


[Attachment #3 (unknown)]

<table><tr><td style="">romangg accepted this revision.<br />romangg added a \
comment.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1230">View \
Revision</a></tr></table><br /><div><div><p>Looks fine to me. Tested runtime together \
with your KWayland patch.</p>

<p>Probably you know this, but please push as one commit only to \
master.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D1230#inline-57873">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">egl_gbm_backend.cpp:160</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">qEnvironmentVariableIsSet</span><span class="p">(</span><span style="color: \
#766510">&quot;KWIN_NO_REMOTE&quot;</span><span class="p">))</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span style="color: #aa4000">return</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use \
braces: <a href="https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces</a></p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>fix-clang</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1230">https://phabricator.kde.org/D1230</a></div></div><br \
/><div><strong>To: </strong>Kanedias, graesslin, davidedmundson, romangg, KWin<br \
/><strong>Cc: </strong>kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, \
KWin, davidedmundson, plasma-devel, ragreen, schernikov, iodelay, zzag, bwowk, \
ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, \
apol, mart, hein<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]