[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11661: Fix wrong X-DocPath in kcm_launchfeedback.desktop
From:       Burkhard_Lück <noreply () phabricator ! kde ! org>
Date:       2018-03-24 21:15:08
Message-ID: 20180324211508.1.3DDF3BA4F793563D () phabricator ! kde ! org
[Download RAW message or body]

lueck created this revision.
lueck added reviewers: Plasma, Localization, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  kcms/launch/kcm_launchfeedback.desktop
  X-DocPath=kcontrol/kcmlaunchfeedback/index.html
  
  doc/kcontrol/kcmlaunch/CMakeLists.txt
  kdoctools_create_handbook(index.docbook INSTALL_DESTINATION \
${KDE_INSTALL_DOCBUNDLEDIR}/en SUBDIR kcontrol/kcmlaunch)  
  kcmlaunch != kcmlaunchfeedback therefore the en_US documentation is not found
  
  Scripty generates the install path from the dir name
  l10n-kf5/[lang]/docs/kde-workspace/kcontrol/kcmlaunch/CMakeLists.txt
  kdoctools_create_handbook(index.docbook INSTALL_DESTINATION \
${HTML_INSTALL_DIR}/${CURRENT_LANG}/ SUBDIR kcontrol/kcmlaunch )  
  We need X-DocPath=kcontrol/kcmlaunch/index.html in the desktop file
  then khelpcenter finds the correct docbook for en_US and all language translations

TEST PLAN
  build and works

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11661

AFFECTED FILES
  kcms/launch/kcm_launchfeedback.desktop

To: lueck, #plasma, #localization, #documentation
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">lueck created this revision.<br />lueck added reviewers: \
Plasma, Localization, Documentation.<br />Restricted Application added a project: \
Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />lueck \
requested review of this revision. </td><a style="text-decoration: none; padding: 4px \
8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11661">View Revision</a></tr></table><br \
/><div><strong>REVISION \
SUMMARY</strong><div><p>kcms/launch/kcm_launchfeedback.desktop<br /> \
X-DocPath=kcontrol/kcmlaunchfeedback/index.html</p>

<p>doc/kcontrol/kcmlaunch/CMakeLists.txt<br />
kdoctools_create_handbook(index.docbook INSTALL_DESTINATION \
${KDE_INSTALL_DOCBUNDLEDIR}/en SUBDIR kcontrol/kcmlaunch)</p>

<p>kcmlaunch != kcmlaunchfeedback therefore the en_US documentation is not found</p>

<p>Scripty generates the install path from the dir name<br />
l10n-kf5/[lang]/docs/kde-workspace/kcontrol/kcmlaunch/CMakeLists.txt<br />
kdoctools_create_handbook(index.docbook INSTALL_DESTINATION \
${HTML_INSTALL_DIR}/${CURRENT_LANG}/ SUBDIR kcontrol/kcmlaunch )</p>

<p>We need X-DocPath=kcontrol/kcmlaunch/index.html in the desktop file<br />
then khelpcenter finds the correct docbook for en_US and all language \
translations</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>build and \
works</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11661">https://phabricator.kde.org/D11661</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>kcms/launch/kcm_launchfeedback.desktop</div></div></div><br \
/><div><strong>To: </strong>lueck, Plasma, Localization, Documentation<br \
/><strong>Cc: </strong>plasma-devel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]