[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D1230: GBM remote access support for KWin
From: Friedrich W. H. Kossebau <noreply () phabricator ! kde ! org>
Date: 2018-03-21 11:55:20
Message-ID: 20180321115520.1.430C87191D64E9FF () phabricator ! kde ! org
[Download RAW message or body]
kossebau added a comment.
In D1230#230642 <https://phabricator.kde.org/D1230#230642>, @romangg wrote:
> In D1230#230613 <https://phabricator.kde.org/D1230#230613>, @Kanedias wrote:
>
> > They don't override anything and compile fails for me if they are present. GCC \
7.3.1. >
>
> I believe this is an unrelated regression you just ran into because of D11209 \
<https://phabricator.kde.org/D11209>. I hadn't yet updated my KDecoration clone, \
that's why it still compiled for me. In any case please remove the unrelated override \
keyword removal from the patch and let's hope the regression will be quickly fixed in \
KDecoration.
No, D11209 <https://phabricator.kde.org/D11209> should be innocent here. Not \
exporting the symbols of the pimpl classes has no effect on the virtualness of the \
methods of the normal classes.
The issue is rather that those tooltip-related methods only got added recently to \
master, see D7246 <https://phabricator.kde.org/D7246>. So KWin master also expects \
KDecoration master.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D1230
To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, \
davidedmundson, plasma-devel, schernikov, iodelay, zzag, bwowk, ZrenBot, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
[Attachment #3 (unknown)]
<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D1230">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D1230#230642" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D1230#230642</a>, <a \
href="https://phabricator.kde.org/p/romangg/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@romangg</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D1230#230613" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D1230#230613</a>, <a \
href="https://phabricator.kde.org/p/Kanedias/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@Kanedias</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>They don't override anything and \
compile fails for me if they are present. GCC 7.3.1.</p></div> </blockquote>
<p>I believe this is an unrelated regression you just ran into because of <a \
href="https://phabricator.kde.org/D11209" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D11209</a>. I hadn't yet \
updated my KDecoration clone, that's why it still compiled for me. In any case \
please remove the unrelated override keyword removal from the patch and let's \
hope the regression will be quickly fixed in KDecoration.</p></div> </blockquote>
<p>No, <a href="https://phabricator.kde.org/D11209" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D11209</a> should be innocent \
here. Not exporting the symbols of the pimpl classes has no effect on the virtualness \
of the methods of the normal classes.</p>
<p>The issue is rather that those tooltip-related methods only got added recently to \
master, see <a href="https://phabricator.kde.org/D7246" style="background-color: \
#e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D7246</a>. So KWin master also \
expects KDecoration master.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1230">https://phabricator.kde.org/D1230</a></div></div><br \
/><div><strong>To: </strong>Kanedias, graesslin, davidedmundson, romangg, KWin<br \
/><strong>Cc: </strong>kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, \
KWin, davidedmundson, plasma-devel, schernikov, iodelay, zzag, bwowk, ZrenBot, \
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, \
mart, hein<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic