[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11021: [Media controller] Add simple volume control
From:       Radek_Hušek <noreply () phabricator ! kde ! org>
Date:       2018-03-20 13:42:47
Message-ID: 20180320134247.1.6B302CFECC810CEB () phabricator ! kde ! org
[Download RAW message or body]

Pitel added inline comments.

INLINE COMMENTS

> broulik wrote in multiplexedservice.h:38
> Shouldn't this be a job? So you use the `startOperationCall` stuff used elsewhere \
> (for e.g. Play and so on)

I guess it would look more consistent if it was a job but somehow I fail to see why \
any of this is job in the first place: all the actions are very simple so offloading \
work to other thread is not needed and it hides interface in ugly way... Do you have \
any insight why?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">Pitel added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11021">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D11021#inline-56753">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">multiplexedservice.h:38</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">Shouldn&#039;t this be a job? So you use the <tt style="background: #ebebeb; \
font-size: 13px;">startOperationCall</tt> stuff used elsewhere (for e.g. Play and so \
on)</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: \
0; margin: 8px;">I guess it would look more consistent if it was a job but somehow I \
fail to see why any of this is job in the first place: all the actions are very \
simple so offloading work to other thread is not needed and it hides interface in \
ugly way... Do you have any insight why?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11021">https://phabricator.kde.org/D11021</a></div></div><br \
/><div><strong>To: </strong>Pitel, Plasma, broulik<br /><strong>Cc: </strong>broulik, \
nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]