[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11198: [libbreezecommon] add box shadow helper
From:       Hugo Pereira Da Costa <noreply () phabricator ! kde ! org>
Date:       2018-03-20 9:06:04
Message-ID: 20180320090604.1.1BD0A6A4095D36E5 () phabricator ! kde ! org
[Download RAW message or body]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Fix it (std::erf), then ship it ! 
  I have had no time to work on an alternative QGradient blur, and wont in the near \
future. In the meanwhile lets use this code (that you have spent quite some time on \
already).   There is still time to revisit it in the future. 
  Thanks !

INLINE COMMENTS

> breezeboxshadowhelper.cpp:41
> +    double kernelNorm = 0.0;
> +    double lastInt = 0.5 * erf((-radius - 0.5) / den);
> +

erf -> std::erf (since c++11). 
same elsewhere. I think it is clearer to add the namespace explicitly, now that it is \
properly defined.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11198

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">hpereiradacosta accepted this revision.<br />hpereiradacosta \
added a comment.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11198">View \
Revision</a></tr></table><br /><div><div><p>Fix it (std::erf), then ship it ! <br /> \
I have had no time to work on an alternative QGradient blur, and wont in the near \
future. In the meanwhile lets use this code (that you have spent quite some time on \
already). <br /> There is still time to revisit it in the future. <br />
Thanks !</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D11198#inline-56734">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">breezeboxshadowhelper.cpp:41</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: \
#aa4000">double</span> <span class="n">kernelNorm</span> <span style="color: \
#aa2211">=</span> <span style="color: #601200">0.0</span><span class="p">;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">    <span style="color: #aa4000">double</span> <span class="n">lastInt</span> \
<span style="color: #aa2211">=</span> <span style="color: #601200">0.5</span> <span \
style="color: #aa2211">*</span> <span class="n">erf</span><span \
class="p">((</span><span style="color: #aa2211">-</span><span class="n">radius</span> \
<span style="color: #aa2211">-</span> <span style="color: #601200">0.5</span><span \
class="p">)</span> <span style="color: #aa2211">/</span> <span \
class="n">den</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">erf \
-&gt; std::erf (since c++11). <br /> same elsewhere. I think it is clearer to add the \
namespace explicitly, now that it is properly \
defined.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11198">https://phabricator.kde.org/D11198</a></div></div><br \
/><div><strong>To: </strong>zzag, Breeze, VDG, hpereiradacosta<br /><strong>Cc: \
</strong>broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]