[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-03-19 3:49:35
Message-ID: 20180319034935.1.FE4E43CE534B12FC () phabricator ! kde ! org
[Download RAW message or body]

ngraham added inline comments.

INLINE COMMENTS

> main_deviceless.qml:62
> +
> +            Column {
> +                spacing: units.smallSpacing * 2

Do you really need to define each individual column like this? Seems like a code small to me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11469

To: romangg, #plasma
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Attachment #3 (unknown)]

<table><tr><td style="">ngraham added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11469">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D11469#inline-56489">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">main_deviceless.qml:62</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span style="color: #004012">Column</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span style="color: #aa4000">spacing:</span> <span style="color: \
#004012">units</span><span class="p">.</span><span style="color: \
#004012">smallSpacing</span> <span style="color: #aa2211">*</span> <span \
style="color: #601200">2</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do \
you really need to define each individual column like this? Seems like a code small \
to me.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11469">https://phabricator.kde.org/D11469</a></div></div><br \
/><div><strong>To: </strong>romangg, Plasma<br /><strong>Cc: </strong>abetts, \
ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]