[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11262: KDE logout screen background color fix
From:       Radek_Hušek <noreply () phabricator ! kde ! org>
Date:       2018-03-13 16:58:32
Message-ID: 20180313165832.1.74C2CB020DE28394 () phabricator ! kde ! org
[Download RAW message or body]

Pitel added a comment.


  I see that relative luminance formula is more correct but I would like to point out \
that we do not need here to calculate precise luminance. The point of the `?:` \
statement is to collapse colors close to back to real black because gray overlay with \
50 % opacity does not look good. So the current formula looks good enough for me and \
I would even think about moving the threshold down a bit to 0.4 or 0.3. (Generally \
not collapsing to black is the save way, it may not look so good but the text will be \
still easy to read.)  
  For reference a screenshot with gray background (similar to default breeze) without \
collapsing it to black: F5752690: Screenshot_20180313_175108.png \
<https://phabricator.kde.org/F5752690>

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">Pitel added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11262">View Revision</a></tr></table><br \
/><div><div><p>I see that relative luminance formula is more correct but I would like \
to point out that we do not need here to calculate precise luminance. The point of \
the <tt style="background: #ebebeb; font-size: 13px;">?:</tt> statement is to \
collapse colors close to back to real black because gray overlay with 50 % opacity \
does not look good. So the current formula looks good enough for me and I would even \
think about moving the threshold down a bit to 0.4 or 0.3. (Generally not collapsing \
to black is the save way, it may not look so good but the text will be still easy to \
read.)</p>

<p>For reference a screenshot with gray background (similar to default breeze) \
without collapsing it to black: <a href="https://phabricator.kde.org/F5752690" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F5752690: \
Screenshot_20180313_175108.png</a></p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11262">https://phabricator.kde.org/D11262</a></div></div><br \
/><div><strong>To: </strong>Pitel, mart, Plasma<br /><strong>Cc: </strong>fredrik, \
ngraham, abetts, broulik, mvourlakos, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]