[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11262: KDE logout screen background color fix
From:       Radek_Hušek <noreply () phabricator ! kde ! org>
Date:       2018-03-12 17:25:55
Message-ID: 20180312172555.1.DA8BDAFC61EC7C4A () phabricator ! kde ! org
[Download RAW message or body]

Pitel added a comment.


  In D11262#224113 <https://phabricator.kde.org/D11262#224113>, @ngraham wrote:
  
  > Would you be interested in producing similar patches for the Lock and Login \
screens, which suffer from the same issue?  >
  > - Login screen: https://bugs.kde.org/show_bug.cgi?id=388622
  > - Lock screen: https://bugs.kde.org/show_bug.cgi?id=369676
  
  
  Those two seem to be a bit more complicated because the logout screen covers the \
desktop by some color overlay so we know how the background looks. But with login & \
lock screen there is only picture on the background and no color overlay.  
  Adding color overlays on them seems unnatural and ugly. Other thing I tried is to \
add Glow effect. It solves readability problem but I do not like how it looks and \
documentation says it also needs OpenGL.  
  Using background dependent color would require to calculate an "average color" of \
an image in qml and I do not see how to do that. So the only solution I see right \
know is to add config options to select text color for lock & login screens.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: ngraham, abetts, broulik, mvourlakos, plasma-devel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">Pitel added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11262">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D11262#224113" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D11262#224113</a>, <a \
href="https://phabricator.kde.org/p/ngraham/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Would you be interested in producing similar \
patches for the Lock and Login screens, which suffer from the same issue?</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Login screen: <a \
href="https://bugs.kde.org/show_bug.cgi?id=388622" class="remarkup-link" \
target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=388622</a></li> \
<li class="remarkup-list-item">Lock screen: <a \
href="https://bugs.kde.org/show_bug.cgi?id=369676" class="remarkup-link" \
target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=369676</a></li> \
</ul></div> </blockquote>

<p>Those two seem to be a bit more complicated because the logout screen covers the \
desktop by some color overlay so we know how the background looks. But with login \
&amp; lock screen there is only picture on the background and no color overlay.</p>

<p>Adding color overlays on them seems unnatural and ugly. Other thing I tried is to \
add Glow effect. It solves readability problem but I do not like how it looks and \
documentation says it also needs OpenGL.</p>

<p>Using background dependent color would require to calculate an &quot;average \
color&quot; of an image in qml and I do not see how to do that. So the only solution \
I see right know is to add config options to select text color for lock &amp; login \
screens.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11262">https://phabricator.kde.org/D11262</a></div></div><br \
/><div><strong>To: </strong>Pitel, mart, Plasma<br /><strong>Cc: </strong>ngraham, \
abetts, broulik, mvourlakos, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]