[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10297: Add new "Tools" button above System Monitor's process list
From:       gregormi <noreply () phabricator ! kde ! org>
Date:       2018-03-07 11:45:49
Message-ID: 20180307114549.1.44EAE784F12910C3 () phabricator ! kde ! org
[Download RAW message or body]

gregormi added a comment.


  In D10297#220548 <https://phabricator.kde.org/D10297#220548>, @rkflx wrote:
  
  > In D10297#220547 <https://phabricator.kde.org/D10297#220547>, @gregormi wrote:
  >
  > > Some people from Plasma reviewed the original review request on reviewboard. \
Should we add some more reviewers before it can go in?  >
  >
  > Only looked at it briefly, but I did not spot something about KSysGuard (the \
multi-page app), it was all about "System Monitor" (the single page dialog) so far. \
Anyway, I'm not the maintainer, I only added a comment about something I noticed.  
  
  I think the reviewers are aware that the menu will also be part of KSysGuard, which \
is a good thing. I added Thomas from the original review request and Friedrich as one \
from the recent commit history as additional reviewers.  
  So the final question to be decided is: "For KSysGuard: is it odd that the new \
tools menu only appears in the System Table tab?" I would follow Nate's assessment \
https://phabricator.kde.org/D10297#207235 here and say no and regarding all \
circumstances it is a good solution.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma, colomar, kossebau
Cc: anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">gregormi added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10297">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D10297#220548" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D10297#220548</a>, <a \
href="https://phabricator.kde.org/p/rkflx/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@rkflx</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D10297#220547" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D10297#220547</a>, <a \
href="https://phabricator.kde.org/p/gregormi/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@gregormi</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Some people from Plasma reviewed the \
original review request on reviewboard. Should we add some more reviewers before it \
can go in?</p></div> </blockquote>

<p>Only looked at it briefly, but I did not spot something about KSysGuard (the \
multi-page app), it was all about &quot;System Monitor&quot; (the single page dialog) \
so far. Anyway, I&#039;m not the maintainer, I only added a comment about something I \
noticed.</p></div> </blockquote>

<p>I think the reviewers are aware that the menu will also be part of KSysGuard, \
which is a good thing. I added Thomas from the original review request and Friedrich \
as one from the recent commit history as additional reviewers.</p>

<p>So the final question to be decided is: &quot;For KSysGuard: is it odd that the \
new tools menu only appears in the System Table tab?&quot; I would follow Nate&#039;s \
assessment <a href="https://phabricator.kde.org/D10297#207235" class="remarkup-link" \
target="_blank" rel="noreferrer">https://phabricator.kde.org/D10297#207235</a> here \
and say no and regarding all circumstances it is a good solution.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R111 KSysguard \
Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10297">https://phabricator.kde.org/D10297</a></div></div><br \
/><div><strong>To: </strong>gregormi, Plasma, colomar, kossebau<br /><strong>Cc: \
</strong>anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]