[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10297: Add new "Tools" button above System Monitor's process list
From:       gregormi <noreply () phabricator ! kde ! org>
Date:       2018-03-07 10:42:08
Message-ID: 20180307104208.1.0737FFEA53707D6F () phabricator ! kde ! org
[Download RAW message or body]

gregormi added a comment.


  In D10297#207127 <https://phabricator.kde.org/D10297#207127>, @rkflx wrote:
  
  > Just tried the patch. I think for System Activity / [Ctrl] + [⎋] the button is \
fine (annoyingly with a slightly larger height than the combobox, but that's \
life…). For KSysGuard itself it looks a bit odd, why would it appear exactly on \
this tab page? I could imagine the menubar would be a better place.  >
  > (Sorry this comes so late, I only reviewed in more detail because nobody from \
Plasma bothered so far. Ignore my comment if you want.)  
  
  Some people from Plasma reviewed the original review request on reviewboard. Should \
we add some more reviewers before it can go in?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma
Cc: anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">gregormi added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10297">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D10297#207127" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D10297#207127</a>, <a \
href="https://phabricator.kde.org/p/rkflx/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@rkflx</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Just tried the patch. I think for \
<span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade \
"><span class="phui-tag-core ">System Activity</span></span></span> / <kbd \
style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: \
normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: \
0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); \
user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">Ctrl</kbd><span \
class="kbd-join" style="padding: 0 4px; color: #92969D;">+</span><kbd title="Escape" \
style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: \
normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: \
0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); \
user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">⎋</kbd> the \
button is fine (annoyingly with a slightly larger height than the combobox, but \
that&#039;s life…). For <span><span class="phui-tag-view phui-tag-type-shade \
phui-tag-grey phui-tag-shade "><span class="phui-tag-core \
">KSysGuard</span></span></span> itself it looks a bit odd, why would it appear \
exactly on this tab page? I could imagine the menubar would be a better place.</p>

<p>(Sorry this comes so late, I only reviewed in more detail because nobody from \
Plasma bothered so far. Ignore my comment if you want.)</p></div> </blockquote>

<p>Some people from Plasma reviewed the original review request on reviewboard. \
Should we add some more reviewers before it can go in?</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R111 KSysguard \
Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10297">https://phabricator.kde.org/D10297</a></div></div><br \
/><div><strong>To: </strong>gregormi, Plasma<br /><strong>Cc: \
</strong>anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]