[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D10195: DrKonqi: Enable DBus-Interface for debugging with KDevelop
From: Milian Wolff <noreply () phabricator ! kde ! org>
Date: 2018-03-04 20:37:47
Message-ID: 20180304203747.1.C7D2548737077D96 () phabricator ! kde ! org
[Download RAW message or body]
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
minor style stuff, otherwise lgtm, esp. if it works now
INLINE COMMENTS
> README:5
>
> -[Drkonqi]
> +[DrKonqi]
> ShowDebugButton=true
could be a separate commit
> debuggerlaunchers.cpp:42
> {
> - if ( qobject_cast<DebuggerManager*>(parent())->debuggerIsRunning() ) {
> + if ( static_cast<DebuggerManager*>(parent())->debuggerIsRunning() ) {
> qWarning() << "Another debugger is already running";
could be a separate commit
> debuggerlaunchers.h:81
> public:
> - explicit DBusOldInterfaceLauncher(DebuggerManager *parent = nullptr);
> + explicit DBusInterfaceLauncher(const QString& name, DBusInterfaceAdaptor* \
> parent = nullptr); QString name() const override;
here and below: style issues, afaik & and * should be next to the var name in \
frameworks code, like done in Qt
REPOSITORY
R871 DrKonqi
BRANCH
kdevelopdbus
REVISION DETAIL
https://phabricator.kde.org/D10195
To: croick, #kdevelop, #plasma_workspaces, mwolff
Cc: mwolff, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">mwolff accepted this revision.<br />mwolff added a \
comment.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10195" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>minor style stuff, \
otherwise lgtm, esp. if it works now</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10195#inline-53304" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">README:5</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">[Dr<span \
class="bright">k</span>onqi] </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">[Dr<span class="bright">K</span>onqi] \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">could be a separate commit</p></div></div><br /><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10195#inline-53303" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">debuggerlaunchers.cpp:42</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; "><span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> \
<span class="p">(</span> <span class="bright"></span><span class="n"><span \
class="bright">qobject</span>_cast</span><span style="color: \
#aa2211"><</span><span class="n">DebuggerManager</span><span style="color: \
#aa2211">*></span><span class="p">(</span><span class="n">parent</span><span \
class="p">())</span><span style="color: #aa2211">-></span><span \
class="n">debuggerIsRunning</span><span class="p">()</span> <span class="p">)</span> \
<span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span \
class="p">(</span> <span class="bright"></span><span style="color: #aa4000"><span \
class="bright">static</span>_cast</span><span style="color: #aa2211"><</span><span \
class="n">DebuggerManager</span><span style="color: #aa2211">*></span><span \
class="p">(</span><span class="n">parent</span><span class="p">())</span><span \
style="color: #aa2211">-></span><span class="n">debuggerIsRunning</span><span \
class="p">()</span> <span class="p">)</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; "> <span class="n">qWarning</span><span \
class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: \
#766510">"Another debugger is already running"</span><span \
class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">could be a separate commit</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10195#inline-53302" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">debuggerlaunchers.h:81</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; "><span style="color: #a0a000">public</span><span class="p">:</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);"> <span class="n">explicit</span> <span class="n">DBus<span \
class="bright">Old</span>InterfaceLauncher</span><span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span class="n"><span \
class="bright">DebuggerManager</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">*</span></span><span \
class="n">parent</span> <span style="color: #aa2211">=</span> <span \
class="n">nullptr</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">explicit</span> <span class="n">DBusInterfaceLauncher</span><span \
class="p">(<span class="bright"></span></span><span class="bright"></span><span \
style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> \
</span><span class="n"><span class="bright">QString</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">&</span></span><span class="bright"> </span><span class="n"><span \
class="bright">name</span></span><span class="bright"></span><span class="p"><span \
class="bright">,</span></span><span class="bright"> </span><span class="n"><span \
class="bright">DBusInterfaceAdaptor</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> \
</span><span class="n">parent</span> <span style="color: #aa2211">=</span> <span \
class="n">nullptr</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; "> <span class="n">QString</span> <span style="color: \
#004012">name</span><span class="p">()</span> <span style="color: \
#aa4000">const</span> <span class="n">override</span><span class="p">;</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">here and below: style issues, afaik & and * should be next to the \
var name in frameworks code, like done in Qt</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R871 DrKonqi</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>kdevelopdbus</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10195" \
rel="noreferrer">https://phabricator.kde.org/D10195</a></div></div><br \
/><div><strong>To: </strong>croick, KDevelop, Plasma: Workspaces, mwolff<br \
/><strong>Cc: </strong>mwolff, ngraham, plasma-devel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic