[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10855: Emit clicked when double click expires
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2018-03-01 16:59:28
Message-ID: 20180301165928.1.06FCF12E5FC44E59 () phabricator ! kde ! org
[Download RAW message or body]

mart added a comment.


  In D10855#215256 <https://phabricator.kde.org/D10855#215256>, @graesslin wrote:
  
  > I kindly ask to look at the discussion ack in reviewboard when I implemented this \
feature. It was one of the most difficult changes to get in and this was the only \
solution we came up with which seemed to satisfy all concerns.  
  
  where is that discussion? could it be linked here? (sorry, I have no recall of it \
so i am not sure even what to search for)  
  personally, I would find this behavior way more intuitive, for the menu button, i \
expect it to open the menu on click, no matter what i configured for double click \
which is a completely different action from the user POV (also given that Windows has \
this behavior since windows95 it's something pretty entrenched in the expected \
behavior for  that menu button)  it's just.. a bit complicated to implement, but \
that's an implementation detail, not to influence the ui... unless it can't really be \
avoided.  Long press on desktop is generally bad, i know we have it for some \
toolbuttonsand for plasmoid handles, but none of them are optimal, toolbuttons should \
definitely be solved, for plasmoids a bit more difficult, but should be improved as \
well  
  looking at the code, it seems to make sense to have a delay that corresponds to the \
double click interval, that may make the popup feel not super immediate(so the timer \
stuff is important is enabled only when the double click to close is enabled), but \
better than the unpredictable and undiscoverable long press.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D10855

To: broulik, #plasma, graesslin
Cc: mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol


[Attachment #3 (unknown)]

<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10855" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D10855#215256" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D10855#215256</a>, <a \
href="https://phabricator.kde.org/p/graesslin/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@graesslin</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I kindly ask to look at the discussion ack \
in reviewboard when I implemented this feature. It was one of the most difficult \
changes to get in and this was the only solution we came up with which seemed to \
satisfy all concerns.</p></div> </blockquote>

<p>where is that discussion? could it be linked here? (sorry, I have no recall of it \
so i am not sure even what to search for)</p>

<p>personally, I would find this behavior way more intuitive, for the menu button, i \
expect it to open the menu on click, no matter what i configured for double click \
which is a completely different action from the user POV (also given that Windows has \
this behavior since windows95 it&#039;s something pretty entrenched in the expected \
behavior for  that menu button)<br /> it&#039;s just.. a bit complicated to \
implement, but that&#039;s an implementation detail, not to influence the ui... \
unless it can&#039;t really be avoided.<br /> Long press on desktop is generally bad, \
i know we have it for some toolbuttonsand for plasmoid handles, but none of them are \
optimal, toolbuttons should definitely be solved, for plasmoids a bit more difficult, \
but should be improved as well</p>

<p>looking at the code, it seems to make sense to have a delay that corresponds to \
the double click interval, that may make the popup feel not super immediate(so the \
timer stuff is important is enabled only when the double click to close is enabled), \
but better than the unpredictable and undiscoverable long press.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R129 Window Decoration \
Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10855" \
rel="noreferrer">https://phabricator.kde.org/D10855</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, graesslin<br /><strong>Cc: \
</strong>mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]