[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-02-28 20:46:31
Message-ID: 20180228204631.1.1121C9B477F687DF () phabricator ! kde ! org
[Download RAW message or body]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Appending `.desktop` is unnecessary and a violation of the AppStream spec. See \
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent
  
  > The ID must follow a reverse-DNS scheme, consisting of {tld}.{vendor}.{product}, \
for example `org.kde.Gwenview` or `com.hugski.ColorHug2`. Ownership of {vendor}.{tld} \
in the domain name system guarantees uniqueness of IDs.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D10920

To: kossebau, sebas, mart, broulik, ngraham
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham \
added a comment.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10920" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Appending <tt \
style="background: #ebebeb; font-size: 13px;">.desktop</tt> is unnecessary and a \
violation of the AppStream spec. See <a \
href="https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent</a></p>


<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>The \
ID must follow a reverse-DNS scheme, consisting of {tld}.{vendor}.{product}, for \
example <tt style="background: #ebebeb; font-size: 13px;">org.kde.Gwenview</tt> or \
<tt style="background: #ebebeb; font-size: 13px;">com.hugski.ColorHug2</tt>. \
Ownership of {vendor}.{tld} in the domain name system guarantees uniqueness of \
IDs.</p></blockquote></div></div><br /><div><strong>REPOSITORY</strong><div><div>R118 \
Plasma SDK</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10920" \
rel="noreferrer">https://phabricator.kde.org/D10920</a></div></div><br \
/><div><strong>To: </strong>kossebau, sebas, mart, broulik, ngraham<br /><strong>Cc: \
</strong>ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]