[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D10901: Add "move to device" functionality to hamburger menu
From: David Rosca <noreply () phabricator ! kde ! org>
Date: 2018-02-27 21:11:03
Message-ID: 20180227211103.1.859CADCE42E97765 () phabricator ! kde ! org
[Download RAW message or body]
drosca added inline comments.
INLINE COMMENTS
> ListItemBase.qml:340
> + var menuItem = newMenuItem();
> + if(type == "sink-input") {
> + menuItem.text = i18nc("Heading for a list of possible output \
> devices (speakers, headphones, ...) to choose", "Play audio using");
`if (`
> ListItemBase.qml:343
> + }
> + else {
> + menuItem.text = i18nc("Heading for a list of possible input \
> devices (built-in microphone, headset, ...) to choose", "Record audio using");
`} else {` on the same line
> ListItemBase.qml:350
> +
> +
> + for (var i = 0; i < sModel.count; ++i) {
extra newline
REVISION DETAIL
https://phabricator.kde.org/D10901
To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">drosca added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10901" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D10901#inline-52345" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">ListItemBase.qml:340</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">var</span> <span style="color: #004012">menuItem</span> <span \
style="color: #aa2211">=</span> <span style="color: #004012">newMenuItem</span><span \
class="p">();</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span \
class="p">(</span><span style="color: #004012">type</span> <span style="color: \
#aa2211">==</span> <span style="color: #766510">"sink-input"</span><span \
class="p">)</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#004012">menuItem</span><span class="p">.</span><span style="color: \
#004012">text</span> <span style="color: #aa2211">=</span> <span style="color: \
#004012">i18nc</span><span class="p">(</span><span style="color: \
#766510">"Heading for a list of possible output devices (speakers, headphones, \
...) to choose"</span><span class="p">,</span> <span style="color: \
#766510">"Play audio using"</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">if \
(</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D10901#inline-52346" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">ListItemBase.qml:343</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="p">}</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">else</span> \
<span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: \
#004012">menuItem</span><span class="p">.</span><span style="color: \
#004012">text</span> <span style="color: #aa2211">=</span> <span style="color: \
#004012">i18nc</span><span class="p">(</span><span style="color: \
#766510">"Heading for a list of possible input devices (built-in microphone, \
headset, ...) to choose"</span><span class="p">,</span> <span style="color: \
#766510">"Record audio using"</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">} else {</tt> on the \
same line</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D10901#inline-52347" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">ListItemBase.qml:350</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">for</span> <span class="p">(</span><span style="color: \
#aa4000">var</span> <span style="color: #004012">i</span> <span style="color: \
#aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span> <span \
style="color: #004012">i</span> <span style="color: #aa2211"><</span> <span \
style="color: #004012">sModel</span><span class="p">.</span><span style="color: \
#004012">count</span><span class="p">;</span> <span style="color: \
#aa2211">++</span><span style="color: #004012">i</span><span class="p">)</span> <span \
class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">extra newline</p></div></div></div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D10901" \
rel="noreferrer">https://phabricator.kde.org/D10901</a></div></div><br \
/><div><strong>To: </strong>Fuchs, broulik, drosca<br /><strong>Cc: </strong>ngraham, \
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic