[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10901: Add "move to device" functionality to hamburger menu
From:       David Rosca <noreply () phabricator ! kde ! org>
Date:       2018-02-27 20:50:02
Message-ID: 20180227205002.1.E2BBFFCD52CAB5AB () phabricator ! kde ! org
[Download RAW message or body]

drosca added a comment.


  +1. No more code comments.
  
  Just a note, we can't guarantee that audio is actually playing from that stream.

INLINE COMMENTS

> drosca wrote in ListItemBase.qml:338
> `sinkView.model.count > 1` -> `sinkView.count`

Sorry about this comment, it's nonsense. It was fine in your fist diff.

It must check `> 1` not just `> 0`.

REVISION DETAIL
  https://phabricator.kde.org/D10901

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Attachment #3 (unknown)]

<table><tr><td style="">drosca added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10901" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>+1. No more code comments.</p>

<p>Just a note, we can&#039;t guarantee that audio is actually playing from that \
stream.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D10901#inline-52319" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">drosca</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">ListItemBase.qml:338</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; \
font-size: 13px;">sinkView.model.count &gt; 1</tt> -&gt; <tt style="background: \
#ebebeb; font-size: 13px;">sinkView.count</tt></p></div></div> <div style="margin: \
8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Sorry about this \
comment, it&#039;s nonsense. It was fine in your fist diff.</p>

<p style="padding: 0; margin: 8px;">It must check <tt style="background: #ebebeb; \
font-size: 13px;">&gt; 1</tt> not just <tt style="background: #ebebeb; font-size: \
13px;">&gt; 0</tt>.</p></div></div></div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D10901" \
rel="noreferrer">https://phabricator.kde.org/D10901</a></div></div><br \
/><div><strong>To: </strong>Fuchs, broulik, drosca<br /><strong>Cc: </strong>ngraham, \
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]