[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10855: Emit clicked when double click expires
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-02-26 10:14:21
Message-ID: 20180226101421.1.2A8A1BA8369D895F () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
broulik added reviewers: Plasma, graesslin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Press and hold isn't particularly intuitive. Instead, when clicked and the mouse \
isn't moved away, the click is emitted (and as such the menu is opened) when the \
double click timeout expires. Press and hold still works mostly for touch input but \
is merged with double click handling to simplify it.

TEST PLAN
  Comes with unit test
  
  - Double click to close still works
  - Clicked, waited, menu opened
  - Pressed and held, waited, menu opened
  - With close on double click disabled behavior is as before, click just opens the \
menu

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D10855

AFFECTED FILES
  autotests/decorationbuttontest.cpp
  src/decorationbutton.cpp
  src/decorationbutton_p.h

To: broulik, #plasma, graesslin
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: \
Plasma, graesslin.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel.<br />broulik requested \
review of this revision. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10855" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Press \
and hold isn&#039;t particularly intuitive. Instead, when clicked and the mouse \
isn&#039;t moved away, the click is emitted (and as such the menu is opened) when the \
double click timeout expires. Press and hold still works mostly for touch input but \
is merged with double click handling to simplify it.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Comes with unit test</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Double click to close still works</li>
<li class="remarkup-list-item">Clicked, waited, menu opened</li>
<li class="remarkup-list-item">Pressed and held, waited, menu opened</li>
<li class="remarkup-list-item">With close on double click disabled behavior is as \
before, click just opens the menu</li> </ul></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R129 Window Decoration \
Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10855" \
rel="noreferrer">https://phabricator.kde.org/D10855</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>autotests/decorationbuttontest.cpp<br \
/> src/decorationbutton.cpp<br />
src/decorationbutton_p.h</div></div></div><br /><div><strong>To: </strong>broulik, \
Plasma, graesslin<br /><strong>Cc: </strong>plasma-devel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]