[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10836: Ensure _NET_CURRENT_DESKTOP is set on startup
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2018-02-25 16:09:18
Message-ID: 20180225160918.1.B5393C18A0D6FE0E () phabricator ! kde ! org
[Download RAW message or body]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  Seems to have regressed in Plasma 5.12 due to code reordering. Now the
  property is explicitly updated once the NETRootInfo is created.
  
  BUG: 391034
  FIXED-IN: 5.12.3

TEST PLAN
  Test case exposing the problem added. Fails without the patch,
  succeeds with the patch.

REPOSITORY
  R108 KWin

BRANCH
  set-current-desktop-on-startup

REVISION DETAIL
  https://phabricator.kde.org/D10836

AFFECTED FILES
  autotests/integration/virtual_desktop_test.cpp
  workspace.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Attachment #3 (unknown)]

<table><tr><td style="">graesslin created this revision.<br />graesslin added \
reviewers: KWin, Plasma.<br />Restricted Application added a project: KWin.<br \
/>Restricted Application added subscribers: kwin, plasma-devel.<br />graesslin \
requested review of this revision.<br />Restricted Application edited projects, added \
Plasma; removed KWin. </td><a style="text-decoration: none; padding: 4px 8px; margin: \
0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10836" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Seems to \
have regressed in Plasma 5.12 due to code reordering. Now the<br /> property is \
explicitly updated once the NETRootInfo is created.</p>

<p>BUG: 391034<br />
FIXED-IN: 5.12.3</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Test \
case exposing the problem added. Fails without the patch,<br /> succeeds with the \
patch.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 \
KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>set-current-desktop-on-startup</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10836" \
rel="noreferrer">https://phabricator.kde.org/D10836</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>autotests/integration/virtual_desktop_test.cpp<br /> \
workspace.cpp</div></div></div><br /><div><strong>To: </strong>graesslin, KWin, \
Plasma<br /><strong>Cc: </strong>plasma-devel, kwin, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]