[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10440: Support modifier mouse/scroll action on internal decorated windows
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2018-02-25 13:32:51
Message-ID: 20180225133251.1.1A06260D81495345 () phabricator ! kde ! org
[Download RAW message or body]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In D10440#213112 <https://phabricator.kde.org/D10440#213112>, @romangg wrote:
  
  > Looks fine, but making this behavior dependent on `isDecorated` seems a bit hacky \
to me. Wouldn't be a separate property for this better? Are all internal windows \
without decoration not movable? What if we want to do it this way at some point in \
the future? We just shouldn't forget about this check here then.  
  
  KWin internal windows are a bit special. Traditionally KWin was not able to manage \
it's own windows which means on X11 they were override redirect. Due to that they are \
not movable. The first ever internal window which is not falling under the \
constraints is the DebugConsole. But also only on Wayland. On X11 it has the same \
restrictions as on Wayland. Due to the restrictions for internal windows I consider \
it as highly unlikely that we will extend this in future. The main difference between \
a normal internal window and the DebugConsole internal window is that it is \
decorated. Other internal windows which are not decorated are also not going to be \
movable. What we currently have are things like the OSD, Overlay, etc. All of them \
not movable. "Real" windows are normally done through spawning a dedicated child \
process (examples: window killer, dialog for fullscreen windows, etc.). This is \
probably also not going to change.  
  So yes the whole thing is kind of hacky, but I think it is acceptable.

REPOSITORY
  R108 KWin

BRANCH
  modifier-click-scroll-decorated-internal-window-5.12

REVISION DETAIL
  https://phabricator.kde.org/D10440

To: graesslin, #kwin, #plasma, romangg
Cc: romangg, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin added a comment.<br />Restricted Application edited \
projects, added KWin; removed Plasma. </td><a style="text-decoration: none; padding: \
4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10440" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D10440#213112" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D10440#213112</a>, <a \
href="https://phabricator.kde.org/p/romangg/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@romangg</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Looks fine, but making this behavior \
dependent on <tt style="background: #ebebeb; font-size: 13px;">isDecorated</tt> seems \
a bit hacky to me. Wouldn&#039;t be a separate property for this better? Are all \
internal windows without decoration not movable? What if we want to do it this way at \
some point in the future? We just shouldn&#039;t forget about this check here \
then.</p></div> </blockquote>

<p>KWin internal windows are a bit special. Traditionally KWin was not able to manage \
it&#039;s own windows which means on X11 they were override redirect. Due to that \
they are not movable. The first ever internal window which is not falling under the \
constraints is the DebugConsole. But also only on Wayland. On X11 it has the same \
restrictions as on Wayland. Due to the restrictions for internal windows I consider \
it as highly unlikely that we will extend this in future. The main difference between \
a normal internal window and the DebugConsole internal window is that it is \
decorated. Other internal windows which are not decorated are also not going to be \
movable. What we currently have are things like the OSD, Overlay, etc. All of them \
not movable. &quot;Real&quot; windows are normally done through spawning a dedicated \
child process (examples: window killer, dialog for fullscreen windows, etc.). This is \
probably also not going to change.</p>

<p>So yes the whole thing is kind of hacky, but I think it is \
acceptable.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 \
KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>modifier-click-scroll-decorated-internal-window-5.12</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10440" \
rel="noreferrer">https://phabricator.kde.org/D10440</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma, romangg<br /><strong>Cc: \
</strong>romangg, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]