[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D10747: Implement zwp_linux_dmabuf_v1
From: Fredrik_Höglund <noreply () phabricator ! kde ! org>
Date: 2018-02-22 15:07:52
Message-ID: 20180222150752.1.0C1B3D47D543E57E () phabricator ! kde ! org
[Download RAW message or body]
fredrik added inline comments.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
INLINE COMMENTS
> linuxdmabuf_v1_interface.h:39
> +
> +namespace LinuxDmabuf
> +{
Do we want these nested namespaces? We could have LinuxDmabufFlags, LinuxDmabufBuffer \
etc. instead.
> linuxdmabuf_v1_interface.h:65
> + */
> + class Buffer {
> + public:
Should the Buffer class use a d-pointer?
> linuxdmabuf_v1_interface.h:107
> + */
> + class Bridge {
> + public:
Is this the solution we want for interfacing with the compositor?
My preference would be to use std::function callbacks, with setters in \
LinuxDmabufUnstableV1Interface. Setting up the interface could then look like this:
m_linuxDmabuf = m_display->createLinuxDmabufInterface(m_display);
m_linuxDmabuf->setQuerySupportedFormats([]{ return \
Compositor::self()->scene()->supportedDrmFormats(); });
...
m_linuxDmabuf->create();
This can also be extended without breaking binary compatibility. But I don't think we \
can use std::function in frameworks. There are also BIC issues when mixing different \
STL implementations, which we may or may not care about.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D10747
To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, schernikov, alexeymin, eliasp, hein
[Attachment #3 (unknown)]
<table><tr><td style="">fredrik added inline comments.<br />Restricted Application \
edited projects, added Plasma; removed Plasma on Wayland. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10747" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10747#inline-51267" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">linuxdmabuf_v1_interface.h:39</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">namespace</span> \
<span class="n">LinuxDmabuf</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do \
we want these nested namespaces? We could have LinuxDmabufFlags, LinuxDmabufBuffer \
etc. instead.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D10747#inline-51265" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">linuxdmabuf_v1_interface.h:65</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> \
*/</span> </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span class="n">class</span> <span class="n">Buffer</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #a0a000">public</span><span \
class="p">:</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Should the Buffer class use a d-pointer?</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10747#inline-51262" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">linuxdmabuf_v1_interface.h:107</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> \
*/</span> </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span class="n">class</span> <span class="n">Bridge</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #a0a000">public</span><span \
class="p">:</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is \
this the solution we want for interfacing with the compositor?</p>
<p style="padding: 0; margin: 8px;">My preference would be to use std::function \
callbacks, with setters in LinuxDmabufUnstableV1Interface. Setting up the interface \
could then look like this:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">m_linuxDmabuf = \
m_display->createLinuxDmabufInterface(m_display); \
m_linuxDmabuf->setQuerySupportedFormats([]{ return \
Compositor::self()->scene()->supportedDrmFormats(); });
...
m_linuxDmabuf->create();</pre></div>
<p style="padding: 0; margin: 8px;">This can also be extended without breaking binary \
compatibility. But I don't think we can use std::function in frameworks. There \
are also BIC issues when mixing different STL implementations, which we may or may \
not care about.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10747" \
rel="noreferrer">https://phabricator.kde.org/D10747</a></div></div><br \
/><div><strong>To: </strong>fredrik, KWin, Plasma, graesslin, davidedmundson, mart<br \
/><strong>Cc: </strong>plasma-devel, Frameworks, michaelh, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, schernikov, alexeymin, \
eliasp, hein<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic