[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10461: GMenu-DBusMenu-Proxy
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-02-14 11:41:07
Message-ID: 20180214114107.1.9B75AA3DD3E6CD5C () phabricator ! kde ! org
[Download RAW message or body]

broulik updated this revision to Diff 27142.
broulik edited the test plan for this revision.
broulik added a comment.


  - Support unity actions (untested)
  - Don't mandate actions to be present, it's perfectly valid for a window to have a \
                menu only consisting of application actions or vice-versa
  - Improve action update logic, signal `ItemsPropertiesUpdated` when an action \
                changes instead of rebuilding the layout
  - Improve menu update logic, just update the existing items when the same number of \
items is removed and added

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10461?vs=27077&id=27142

REVISION DETAIL
  https://phabricator.kde.org/D10461

AFFECTED FILES
  CMakeLists.txt
  gmenu-dbusmenu-proxy/CMakeLists.txt
  gmenu-dbusmenu-proxy/gdbusmenutypes_p.cpp
  gmenu-dbusmenu-proxy/gdbusmenutypes_p.h
  gmenu-dbusmenu-proxy/gmenudbusmenuproxy.desktop
  gmenu-dbusmenu-proxy/main.cpp
  gmenu-dbusmenu-proxy/menu.cpp
  gmenu-dbusmenu-proxy/menu.h
  gmenu-dbusmenu-proxy/menuproxy.cpp
  gmenu-dbusmenu-proxy/menuproxy.h

To: broulik, #plasma
Cc: rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">broulik updated this revision to Diff 27142.<br />broulik \
edited the test plan for this revision. <a \
href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-y4flffcc7gexdpw/" \
rel="noreferrer">(Show Details)</a><br />broulik added a comment. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10461" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><ul \
class="remarkup-list"> <li class="remarkup-list-item">Support unity actions \
(untested)</li> <li class="remarkup-list-item">Don&#039;t mandate actions to be \
present, it&#039;s perfectly valid for a window to have a menu only consisting of \
application actions or vice-versa</li> <li class="remarkup-list-item">Improve action \
update logic, signal <tt style="background: #ebebeb; font-size: \
13px;">ItemsPropertiesUpdated</tt> when an action changes instead of rebuilding the \
layout</li> <li class="remarkup-list-item">Improve menu update logic, just update the \
existing items when the same number of items is removed and added</li> \
</ul></div></div><br /><div><strong>CHANGES TO TEST PLAN</strong><div><div \
style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px \
0;">...</div>Does not work with Gimp or Inkscape as they aren&#039;t GTK3-based.<span \
style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br /> \
<br /> Out of the box it seems to work with most GTK3 apps (tried shotwell, \
gnome-builder, gnote, evince) and you get the &quot;application menu&quot; with few \
items like New Window, Options, Quit.<br /> Together with appmenu-gtk-module and \
`GTK_MODULES=appmenu-gtk-module` I managed to get a full menu bar in pluma \
(editor),</span></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>CHANGES SINCE LAST \
UPDATE</strong><div><a \
href="https://phabricator.kde.org/D10461?vs=27077&amp;id=27142" \
rel="noreferrer">https://phabricator.kde.org/D10461?vs=27077&amp;id=27142</a></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10461" \
rel="noreferrer">https://phabricator.kde.org/D10461</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br /> \
gmenu-dbusmenu-proxy/CMakeLists.txt<br /> \
gmenu-dbusmenu-proxy/gdbusmenutypes_p.cpp<br /> \
gmenu-dbusmenu-proxy/gdbusmenutypes_p.h<br /> \
gmenu-dbusmenu-proxy/gmenudbusmenuproxy.desktop<br /> \
gmenu-dbusmenu-proxy/main.cpp<br /> gmenu-dbusmenu-proxy/menu.cpp<br />
gmenu-dbusmenu-proxy/menu.h<br />
gmenu-dbusmenu-proxy/menuproxy.cpp<br />
gmenu-dbusmenu-proxy/menuproxy.h</div></div></div><br /><div><strong>To: \
</strong>broulik, Plasma<br /><strong>Cc: </strong>rk, rilian, mtallur, ngraham, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]