[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10170: Added optional transparency/blur to menu frames
From:       Hugo Pereira Da Costa <noreply () phabricator ! kde ! org>
Date:       2018-02-12 14:06:52
Message-ID: 20180212140652.1.A65ECA0D655188F5 () phabricator ! kde ! org
[Download RAW message or body]

hpereiradacosta added a comment.


  last round of modifications: simplifications of the blurHelper class. 
  Also, for the config ui, maybe it makes more sense to call the "Transparency" tab, \
only "Menus" and change "Menu:" into "Transparency:"  Unless of course one wants to \
add transparency behind other widgets.  
  Then I think it is good to go.

INLINE COMMENTS

> breezeblurhelper.h:138
> +
> +#endif

Because the use of this class is much simplified wrt the original one, it can be \
significantly simplified:

_timer (and timerEvent) are unnecessary.
Then update() could be removed, as well as _widgets, as well as the widgetDestroyed \
callback. Then update(widget) could be called directly in the event filter.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">hpereiradacosta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10170" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>last round of modifications: \
simplifications of the blurHelper class. <br /> Also, for the config ui, maybe it \
makes more sense to call the &quot;Transparency&quot; tab, only &quot;Menus&quot; and \
change &quot;Menu:&quot; into &quot;Transparency:&quot;<br /> Unless of course one \
wants to add transparency behind other widgets.</p>

<p>Then I think it is good to go.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10170#inline-49228" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">breezeblurhelper.h:138</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; color: #888888;">(Empty.)</div></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">Because the use of this class \
is much simplified wrt the original one, it can be significantly simplified:</p>

<p style="padding: 0; margin: 8px;">_timer (and timerEvent) are unnecessary.<br />
Then update() could be removed, as well as _widgets, as well as the widgetDestroyed \
callback.<br /> Then update(widget) could be called directly in the event \
filter.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10170" \
rel="noreferrer">https://phabricator.kde.org/D10170</a></div></div><br \
/><div><strong>To: </strong>anemeth, hpereiradacosta, Plasma, colomar, alake<br \
/><strong>Cc: </strong>fredrik, alake, januz, abetts, colomar, andreask, zzag, \
ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]