[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: plasma-desktop-5.12.0 bug report
From:       Marco Martin <notmart () gmail ! com>
Date:       2018-02-08 16:22:11
Message-ID: 6840265.RKLkQpbP3r () phobos
[Download RAW message or body]

Hi,
thanks for the report!
however, please consider to use bugzilla at bugs.kde.org
product: plasmashell

On giovedì 8 febbraio 2018 10:07:23 CET David Binderman wrote:
> Hello there,
> 
> 
> 
> plasma-desktop-5.12.0/kcms/kfontinst/lib/Misc.cpp:294]: (style) Same
> expression on both sides of '||'.
> 
> Source code is
> 
> 
>     return "font/otf"==mime || "font/ttf"==mime ||
>            "application/x-font-type1"==mime ||
> "application/x-font-ttf"==mime || "application/x-font-otf"==mime ||
> "application/x-font-type1"==mime;
> 
> x-font-type1 gets mentioned twice. Suggest code rework.
> 
> 
> Regards
> 
> 
> David Binderman


-- 
Marco Martin
[prev in list] [next in list] [prev in thread] [next in thread]