[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10217: Choose source with a combobox, but only on the desktop view
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-01-31 22:07:21
Message-ID: 20180131220721.1.83BDC71DEB280DB8 () phabricator ! kde ! org
[Download RAW message or body]

ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Here I am again, hawking my combobox... :)
  
  This patch uses a combobox to select the source, but only for the desktop view. \
People are always complaining that Discover's desktop view doesn't feel like a \
desktop app, and using a desktop-metaphor UI element here would help the situation, I \
believe.  
  On mobile, the UI is unchanged, and we show the overlay, which has always felt more \
mobile-like anyway. It's more at home on that view.  
  When there is only a single source, we show a simple label for both desktop and \
mobile.

TEST PLAN
  Tested in KDE Neon. Source switching still works for all views and apps.
  
  Desktop view, single source:
  
  Desktop view, multiple sources:
  
  Desktop view, source chooser in action:
  
  Mobile view, single source:
  
  Mobile view, multiple sources:
  
  Mobile view, source chooser in action:

REPOSITORY
  R134 Discover Software Store

BRANCH
  combobox-on-desktop

REVISION DETAIL
  https://phabricator.kde.org/D10217

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">ngraham created this revision.<br />ngraham added reviewers: \
apol, Discover Software Store, VDG.<br />Restricted Application added a project: \
Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />ngraham \
requested review of this revision. </td><a style="text-decoration: none; padding: 4px \
8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10217" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Here I \
am again, hawking my combobox... :)</p>

<p>This patch uses a combobox to select the source, but only for the desktop view. \
People are always complaining that Discover&#039;s desktop view doesn&#039;t feel \
like a desktop app, and using a desktop-metaphor UI element here would help the \
situation, I believe.</p>

<p>On mobile, the UI is unchanged, and we show the overlay, which has always felt \
more mobile-like anyway. It&#039;s more at home on that view.</p>

<p>When there is only a single source, we show a simple label for both desktop and \
mobile.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Tested in KDE \
Neon. Source switching still works for all views and apps.</p>

<p>Desktop view, single source:</p>

<p>Desktop view, multiple sources:</p>

<p>Desktop view, source chooser in action:</p>

<p>Mobile view, single source:</p>

<p>Mobile view, multiple sources:</p>

<p>Mobile view, source chooser in action:</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R134 Discover Software \
Store</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>combobox-on-desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10217" \
rel="noreferrer">https://phabricator.kde.org/D10217</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>discover/qml/ApplicationPage.qml</div></div></div><br \
/><div><strong>To: </strong>ngraham, apol, Discover Software Store, VDG<br \
/><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]