--ad036aeb5b624b86b9f91d6bd598fbf7 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="ascii" Mime-Version: 1.0 mart added inline comments. INLINE COMMENTS > DefaultListItemBackground.qml:25 > id: background > - color: listItem.checked || (listItem.supportsMouseEvents && listItem.pressed && !listItem.checked && !listItem.sectionDelegate) ? (internal.indicateActiveFocus ? listItem.activeBackgroundColor : Qt.tint(listItem.backgroundColor, Qt.rgba(listItem.activeBackgroundColor.r, listItem.activeBackgroundColor.g, listItem.activeBackgroundColor.b, 0.3))) : listItem.backgroundColor > + color: listItem.selected || (listItem.supportsMouseEvents && listItem.pressed && !listItem.selected && !listItem.sectionDelegate) ? (internal.indicateActiveFocus ? listItem.activeBackgroundColor : Qt.tint(listItem.backgroundColor, Qt.rgba(listItem.activeBackgroundColor.r, listItem.activeBackgroundColor.g, listItem.activeBackgroundColor.b, 0.3))) : listItem.backgroundColor > the bug is actually in that Qt.tint() call which was trying to generate the inactive selection color, but is wrong. the background color should still change like it did, like everything else (like the dolphin sidebar does for instance) if we want to disable it, we should disable it globally, and is a checkbox in the colors kcm REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10200 To: sebas, hein, mart Cc: plasma-devel, apol, davidedmundson, mart, hein --ad036aeb5b624b86b9f91d6bd598fbf7 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="ascii" Mime-Version: 1.0
mart added inline comments. | View Revision
the bug is actually in that Qt.tint() call which was trying to ge= nerate the inactive selection color, but is wrong.
the background color should still cha= nge like it did, like everything else (like the dolphin sidebar does for in= stance) if we want to disable it, we should disable it globally, and is a c= heckbox in the colors kcm