From kde-panel-devel  Wed Jan 31 11:47:03 2018
From: Marco Martin <noreply () phabricator ! kde ! org>
Date: Wed, 31 Jan 2018 11:47:03 +0000
To: kde-panel-devel
Subject: D10200: base listitemdelegate color on selected, not checked
Message-Id: <20180131114703.1.175D409A67C26E89 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=151739923916658
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--ad036aeb5b624b86b9f91d6bd598fbf7"

--ad036aeb5b624b86b9f91d6bd598fbf7
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

mart added inline comments.

INLINE COMMENTS

> DefaultListItemBackground.qml:25
>      id: background
> -    color: listItem.checked || (listItem.supportsMouseEvents && listItem.pressed && !listItem.checked && !listItem.sectionDelegate) ? (internal.indicateActiveFocus ? listItem.activeBackgroundColor : Qt.tint(listItem.backgroundColor, Qt.rgba(listItem.activeBackgroundColor.r, listItem.activeBackgroundColor.g, listItem.activeBackgroundColor.b, 0.3))) : listItem.backgroundColor
> +    color: listItem.selected || (listItem.supportsMouseEvents && listItem.pressed && !listItem.selected && !listItem.sectionDelegate) ? (internal.indicateActiveFocus ? listItem.activeBackgroundColor : Qt.tint(listItem.backgroundColor, Qt.rgba(listItem.activeBackgroundColor.r, listItem.activeBackgroundColor.g, listItem.activeBackgroundColor.b, 0.3))) : listItem.backgroundColor
>  

the bug is actually in that Qt.tint() call which was trying to generate the inactive selection color, but is wrong.

the background color should still change like it did, like everything else (like the dolphin sidebar does for instance) if we want to disable it, we should disable it globally, and is a checkbox in the colors kcm

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10200

To: sebas, hein, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

--ad036aeb5b624b86b9f91d6bd598fbf7
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">mart added inline comments.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D10200" rel=3D"noreferrer">View Revision</a=
></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style=3D=
"margin: 6px 0 12px 0;"><div style=3D"border: 1px solid #C7CCD9; border-rad=
ius: 3px;"><div style=3D"padding: 0; background: #F7F7F7; border-color: #e3=
e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style=
=3D"color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden=
;"><a style=3D"float: right; text-decoration: none;" href=3D"https://phabri=
cator.kde.org/D10200#inline-47048" rel=3D"noreferrer">View Inline</a><span =
style=3D"color: #4b4d51; font-weight: bold;">DefaultListItemBackground.qml:=
25</span></div>
<div style=3D"font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quo=
t;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px=
 0; margin: 0;"><div style=3D"padding: 0 8px; margin: 0 4px; ">    <span st=
yle=3D"color: #aa4000">id: background</span>
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: rgba(251, 17=
5, 175, .7);">    <span style=3D"color: #aa4000">color:</span> <span style=
=3D"color: #004012">listItem</span><span class=3D"p">.<span class=3D"bright=
"></span></span><span class=3D"bright"></span><span style=3D"color: #004012=
"><span class=3D"bright">checked</span></span><span class=3D"bright"> </spa=
n><span style=3D"color: #aa2211"><span class=3D"bright">||</span></span><sp=
an class=3D"bright"> </span><span class=3D"p"><span class=3D"bright">(</spa=
n></span><span class=3D"bright"></span><span style=3D"color: #004012"><span=
 class=3D"bright">listItem</span></span><span class=3D"bright"></span><span=
 class=3D"p"><span class=3D"bright">.</span></span><span class=3D"bright"><=
/span><span style=3D"color: #004012"><span class=3D"bright">supportsMouseEv=
ents</span></span><span class=3D"bright"> </span><span style=3D"color: #aa2=
211"><span class=3D"bright">&amp;&amp;</span></span><span class=3D"bright">=
 </span><span style=3D"color: #004012"><span class=3D"bright">listItem</spa=
n></span><span class=3D"bright"></span><span class=3D"p"><span class=3D"bri=
ght">.</span></span><span class=3D"bright"></span><span style=3D"color: #00=
4012"><span class=3D"bright">pressed</span></span><span class=3D"bright"> <=
/span><span style=3D"color: #aa2211"><span class=3D"bright">&amp;&amp;</spa=
n></span><span class=3D"bright"> </span><span style=3D"color: #aa2211"><spa=
n class=3D"bright">!</span></span><span class=3D"bright"></span><span style=
=3D"color: #004012"><span class=3D"bright">listItem</span></span><span clas=
s=3D"bright"></span><span class=3D"p"><span class=3D"bright">.</span></span=
><span class=3D"bright"></span><span style=3D"color: #004012"><span class=
=3D"bright">check</span>ed</span> <span style=3D"color: #aa2211">&amp;&amp;=
</span> <span style=3D"color: #aa2211">!</span><span style=3D"color: #00401=
2">listItem</span><span class=3D"p">.</span><span style=3D"color: #004012">=
sectionDelegate</span><span class=3D"p">)</span> <span style=3D"color: #aa2=
211">?</span> <span class=3D"p">(</span><span style=3D"color: #004012">inte=
rnal</span><span class=3D"p">.</span><span style=3D"color: #004012">indicat=
eActiveFocus</span> <span style=3D"color: #aa2211">?</span> <span style=3D"=
color: #aa4000">listItem.activeBackgroundColor :</span> <span style=3D"colo=
r: #004012">Qt</span><span class=3D"p">.</span><span style=3D"color: #00401=
2">tint</span><span class=3D"p">(</span><span style=3D"color: #004012">list=
Item</span><span class=3D"p">.</span><span style=3D"color: #004012">backgro=
undColor</span><span class=3D"p">,</span> <span style=3D"color: #004012">Qt=
</span><span class=3D"p">.</span><span style=3D"color: #004012">rgba</span>=
<span class=3D"p">(</span><span style=3D"color: #004012">listItem</span><sp=
an class=3D"p">.</span><span style=3D"color: #004012">activeBackgroundColor=
</span><span class=3D"p">.</span><span style=3D"color: #004012">r</span><sp=
an class=3D"p">,</span> <span style=3D"color: #004012">listItem</span><span=
 class=3D"p">.</span><span style=3D"color: #004012">activeBackgroundColor</=
span><span class=3D"p">.</span><span style=3D"color: #004012">g</span><span=
 class=3D"p">,</span> <span style=3D"color: #004012">listItem</span><span c=
lass=3D"p">.</span><span style=3D"color: #004012">activeBackgroundColor</sp=
an><span class=3D"p">.</span><span style=3D"color: #004012">b</span><span c=
lass=3D"p">,</span> <span style=3D"color: #601200">0.3</span><span class=3D=
"p">)))</span> <span style=3D"color: #aa2211">:</span> <span style=3D"color=
: #004012">listItem</span><span class=3D"p">.</span><span style=3D"color: #=
004012">backgroundColor</span>
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: rgba(151, 23=
4, 151, .6);">    <span style=3D"color: #aa4000">color:</span> <span style=
=3D"color: #004012">listItem</span><span class=3D"p">.<span class=3D"bright=
"></span></span><span class=3D"bright"></span><span style=3D"color: #004012=
"><span class=3D"bright">selected</span></span><span class=3D"bright"> </sp=
an><span style=3D"color: #aa2211"><span class=3D"bright">||</span></span><s=
pan class=3D"bright"> </span><span class=3D"p"><span class=3D"bright">(</sp=
an></span><span class=3D"bright"></span><span style=3D"color: #004012"><spa=
n class=3D"bright">listItem</span></span><span class=3D"bright"></span><spa=
n class=3D"p"><span class=3D"bright">.</span></span><span class=3D"bright">=
</span><span style=3D"color: #004012"><span class=3D"bright">supportsMouseE=
vents</span></span><span class=3D"bright"> </span><span style=3D"color: #aa=
2211"><span class=3D"bright">&amp;&amp;</span></span><span class=3D"bright"=
> </span><span style=3D"color: #004012"><span class=3D"bright">listItem</sp=
an></span><span class=3D"bright"></span><span class=3D"p"><span class=3D"br=
ight">.</span></span><span class=3D"bright"></span><span style=3D"color: #0=
04012"><span class=3D"bright">pressed</span></span><span class=3D"bright"> =
</span><span style=3D"color: #aa2211"><span class=3D"bright">&amp;&amp;</sp=
an></span><span class=3D"bright"> </span><span style=3D"color: #aa2211"><sp=
an class=3D"bright">!</span></span><span class=3D"bright"></span><span styl=
e=3D"color: #004012"><span class=3D"bright">listItem</span></span><span cla=
ss=3D"bright"></span><span class=3D"p"><span class=3D"bright">.</span></spa=
n><span class=3D"bright"></span><span style=3D"color: #004012"><span class=
=3D"bright">select</span>ed</span> <span style=3D"color: #aa2211">&amp;&amp=
;</span> <span style=3D"color: #aa2211">!</span><span style=3D"color: #0040=
12">listItem</span><span class=3D"p">.</span><span style=3D"color: #004012"=
>sectionDelegate</span><span class=3D"p">)</span> <span style=3D"color: #aa=
2211">?</span> <span class=3D"p">(</span><span style=3D"color: #004012">int=
ernal</span><span class=3D"p">.</span><span style=3D"color: #004012">indica=
teActiveFocus</span> <span style=3D"color: #aa2211">?</span> <span style=3D=
"color: #aa4000">listItem.activeBackgroundColor :</span> <span style=3D"col=
or: #004012">Qt</span><span class=3D"p">.</span><span style=3D"color: #0040=
12">tint</span><span class=3D"p">(</span><span style=3D"color: #004012">lis=
tItem</span><span class=3D"p">.</span><span style=3D"color: #004012">backgr=
oundColor</span><span class=3D"p">,</span> <span style=3D"color: #004012">Q=
t</span><span class=3D"p">.</span><span style=3D"color: #004012">rgba</span=
><span class=3D"p">(</span><span style=3D"color: #004012">listItem</span><s=
pan class=3D"p">.</span><span style=3D"color: #004012">activeBackgroundColo=
r</span><span class=3D"p">.</span><span style=3D"color: #004012">r</span><s=
pan class=3D"p">,</span> <span style=3D"color: #004012">listItem</span><spa=
n class=3D"p">.</span><span style=3D"color: #004012">activeBackgroundColor<=
/span><span class=3D"p">.</span><span style=3D"color: #004012">g</span><spa=
n class=3D"p">,</span> <span style=3D"color: #004012">listItem</span><span =
class=3D"p">.</span><span style=3D"color: #004012">activeBackgroundColor</s=
pan><span class=3D"p">.</span><span style=3D"color: #004012">b</span><span =
class=3D"p">,</span> <span style=3D"color: #601200">0.3</span><span class=
=3D"p">)))</span> <span style=3D"color: #aa2211">:</span> <span style=3D"co=
lor: #004012">listItem</span><span class=3D"p">.</span><span style=3D"color=
: #004012">backgroundColor</span>
</div></div></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">the bug is actually in that Qt.tint() call which was trying to ge=
nerate the inactive selection color, but is wrong.</p>

<p style=3D"padding: 0; margin: 8px;">the background color should still cha=
nge like it did, like everything else (like the dolphin sidebar does for in=
stance) if we want to disable it, we should disable it globally, and is a c=
heckbox in the colors kcm</p></div></div></div></div></div><br /><div><stro=
ng>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><=
strong>REVISION DETAIL</strong><div><a href=3D"https://phabricator.kde.org/=
D10200" rel=3D"noreferrer">https://phabricator.kde.org/D10200</a></div></di=
v><br /><div><strong>To: </strong>sebas, hein, mart<br /><strong>Cc: </stro=
ng>plasma-devel, apol, davidedmundson, mart, hein<br /></div>
--ad036aeb5b624b86b9f91d6bd598fbf7--