[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10200: base listitemdelegate color on selected, not checked
From:       Sebastian_Kügler <noreply () phabricator ! kde ! org>
Date:       2018-01-31 11:12:21
Message-ID: 20180131111221.1.1440C6DEF9FEE7F5 () phabricator ! kde ! org
[Download RAW message or body]

sebas created this revision.
sebas added reviewers: hein, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
sebas requested review of this revision.

REVISION SUMMARY
  I can't say that I'm grasping the logic here completely, buuuuut...
  
  In systemsettings, the delegates for categories change color after being
  clicked a second time. As far as I understand, this happens because
  they're checked the first time clicked, then unchecked. The seond time
  clicked should leave them selected (and thus in the same color), and the
  reverse logic is to base the color on the selected property, not the
  checked property.
  
  Am I correct, though?

TEST PLAN
  started system settings, selected a category, selected the same category, color stays the same

REPOSITORY
  R169 Kirigami

BRANCH
  sebas/syselistitemdelegate

REVISION DETAIL
  https://phabricator.kde.org/D10200

AFFECTED FILES
  src/controls/BasicListItem.qml
  src/controls/private/DefaultListItemBackground.qml

To: sebas, hein, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

[Attachment #3 (unknown)]

<table><tr><td style="">sebas created this revision.<br />sebas added reviewers: \
hein, mart.<br />Restricted Application added a project: Kirigami.<br />Restricted \
Application added a subscriber: plasma-devel.<br />sebas requested review of this \
revision. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10200" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>I \
can&#039;t say that I&#039;m grasping the logic here completely, buuuuut...</p>

<p>In systemsettings, the delegates for categories change color after being<br />
clicked a second time. As far as I understand, this happens because<br />
they&#039;re checked the first time clicked, then unchecked. The seond time<br />
clicked should leave them selected (and thus in the same color), and the<br />
reverse logic is to base the color on the selected property, not the<br />
checked property.</p>

<p>Am I correct, though?</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>started system settings, selected a category, selected the same \
category, color stays the same</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>sebas/syselistitemdelegate</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10200" \
rel="noreferrer">https://phabricator.kde.org/D10200</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>src/controls/BasicListItem.qml<br /> \
src/controls/private/DefaultListItemBackground.qml</div></div></div><br \
/><div><strong>To: </strong>sebas, hein, mart<br /><strong>Cc: </strong>plasma-devel, \
apol, davidedmundson, mart, hein<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]