[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10197: Fix krunner's alt+f2 on wayland
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-01-30 23:59:42
Message-ID: 20180130235942.1.BFEBAFEEBD4767F9 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added inline comments.

INLINE COMMENTS

> view.cpp:236
> if (m_plasmaShell && event->type() == QEvent::Expose) {
> using namespace KWayland::Client;
> auto ee = static_cast<QExposeEvent*>(event);

This code here is definitely not designed for X11

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10197

To: apol, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10197" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D10197#inline-47013" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">view.cpp:236</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    \
<span style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">m_plasmaShell</span> <span style="color: #aa2211">&amp;&amp;</span> <span \
class="n">event</span><span style="color: #aa2211">-&gt;</span><span \
class="n">type</span><span class="p">()</span> <span style="color: #aa2211">==</span> \
<span class="n">QEvent</span><span style="color: #aa2211">::</span><span \
class="n">Expose</span><span class="p">)</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; ">        <span style="color: \
#aa4000">using</span> <span style="color: #aa4000">namespace</span> <span \
class="n">KWayland</span><span style="color: #aa2211">::</span><span \
class="n">Client</span><span class="p">;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; ">        <span style="color: #aa4000">auto</span> <span \
class="n">ee</span> <span style="color: #aa2211">=</span> <span style="color: \
#aa4000">static_cast</span><span style="color: #aa2211">&lt;</span><span \
class="n">QExposeEvent</span><span style="color: #aa2211">*&gt;</span><span \
class="p">(</span><span class="n">event</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">This code here is definitely not designed for \
X11</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10197" \
rel="noreferrer">https://phabricator.kde.org/D10197</a></div></div><br \
/><div><strong>To: </strong>apol, Plasma<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]