[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D10188: Sanitise notification HTML
From: Fabian Vogt <noreply () phabricator ! kde ! org>
Date: 2018-01-30 12:07:52
Message-ID: 20180130120752.1.95B7BE1E98C096F6 () phabricator ! kde ! org
[Download RAW message or body]
fvogt added inline comments.
INLINE COMMENTS
> notificationsanitizer.cpp:34
> + t.replace(QLatin1String("\n"), QStringLiteral("<br/>"));
> + // Now remove all inner whitespace (\ns are already <br/>s
> + t = t.simplified();
Missing `)`
> notificationsanitizer.cpp:57
> + const QString name = r.name().toString();
> + if (allowedTags.contains(name)) {
> + out.writeStartElement(name);
Invert this and `continue` instead?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10188
To: davidedmundson, #plasma, fvogt
Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">fvogt added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10188" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D10188#inline-46935" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">notificationsanitizer.cpp:34</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">t</span><span class="p">.</span><span class="n">replace</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
style="color: #766510">"</span><span style="color: #bb6622">\n</span><span \
style="color: #766510">"</span><span class="p">),</span> <span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"<br/>"</span><span class="p">));</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #74777d">// Now remove all inner whitespace (\ns are already \
<br/>s</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">t</span> <span style="color: \
#aa2211">=</span> <span class="n">t</span><span class="p">.</span><span \
class="n">simplified</span><span class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Missing <tt style="background: #ebebeb; font-size: \
13px;">)</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D10188#inline-46934" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">notificationsanitizer.cpp:57</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">const</span> <span class="n">QString</span> <span class="n">name</span> \
<span style="color: #aa2211">=</span> <span class="n">r</span><span \
class="p">.</span><span class="n">name</span><span class="p">().</span><span \
class="n">toString</span><span class="p">();</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">if</span> <span class="p">(</span><span class="n">allowedTags</span><span \
class="p">.</span><span class="n">contains</span><span class="p">(</span><span \
class="n">name</span><span class="p">))</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">out</span><span class="p">.</span><span \
class="n">writeStartElement</span><span class="p">(</span><span \
class="n">name</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Invert this and <tt style="background: #ebebeb; font-size: 13px;">continue</tt> \
instead?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10188" \
rel="noreferrer">https://phabricator.kde.org/D10188</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, fvogt<br /><strong>Cc: \
</strong>fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic