[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10183: Adjust spacing between text and plotter line in Speed tab of nm applet
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-01-29 19:10:12
Message-ID: 20180129191012.1.E373D9DEDBE98B21 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  Looks good. +1
  
  1 minor nitpick, but it's not super important.

INLINE COMMENTS

> TrafficMonitor.qml:55
> left: parent.left
> -            leftMargin: units.iconSizes.medium
> +            leftMargin: units.iconSizes.large
> right: parent.right

Semantically it's weird to use the size of an icon for a margin, unless you're trying \
to line up with an icon. There's a medium sized icon in the toolbar, which I assume \
is the intent here.

Can you rewrite this as "units.iconSizes.medium + largeSpacing"

Should equate to the same value, but self-documents what it's actually doing and \
handles a user changing icon sizes in the config file.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D10183

To: kamathraghavendra, davidedmundson, #plasma, broulik, jgrulich
Cc: ngraham, plasma-devel, davidedmundson, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10183" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Looks good. +1</p>

<p>1 minor nitpick, but it&#039;s not super important.</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10183#inline-46875" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">TrafficMonitor.qml:55</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">            <span style="color: #aa4000">left:</span> <span \
style="color: #004012">parent</span><span class="p">.</span><span style="color: \
#004012">left</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);">            <span style="color: #aa4000">leftMargin:</span> \
<span style="color: #004012">units</span><span class="p">.</span><span style="color: \
#004012">iconSizes</span><span class="p">.<span class="bright"></span></span><span \
class="bright"></span><span style="color: #004012"><span \
class="bright">medium</span></span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">            <span style="color: \
#aa4000">leftMargin:</span> <span style="color: #004012">units</span><span \
class="p">.</span><span style="color: #004012">iconSizes</span><span class="p">.<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#004012"><span class="bright">large</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; ">            <span style="color: #aa4000">right:</span> <span \
style="color: #004012">parent</span><span class="p">.</span><span style="color: \
#004012">right</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Semantically it&#039;s weird to use the size of an icon for a margin, unless \
you&#039;re trying to line up with an icon. There&#039;s a medium sized icon in the \
toolbar, which I assume is the intent here.</p>

<p style="padding: 0; margin: 8px;">Can you rewrite this as \
&quot;units.iconSizes.medium + largeSpacing&quot;</p>

<p style="padding: 0; margin: 8px;">Should equate to the same value, but \
self-documents what it&#039;s actually doing and handles a user changing icon sizes \
in the config file.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R116 Plasma Network Management \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10183" \
rel="noreferrer">https://phabricator.kde.org/D10183</a></div></div><br \
/><div><strong>To: </strong>kamathraghavendra, davidedmundson, Plasma, broulik, \
jgrulich<br /><strong>Cc: </strong>ngraham, plasma-devel, davidedmundson, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]