[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D10183: Adjust spacing between text and plotter line in Speed tab of nm applet
From: Raghavendra Kamath <noreply () phabricator ! kde ! org>
Date: 2018-01-29 19:49:28
Message-ID: 20180129194928.1.409788C31B8802F7 () phabricator ! kde ! org
[Download RAW message or body]
kamathraghavendra added inline comments.
INLINE COMMENTS
> davidedmundson wrote in TrafficMonitor.qml:55
> Semantically it's weird to use the size of an icon for a margin, unless you're \
> trying to line up with an icon. There's a medium sized icon in the toolbar, which I \
> assume is the intent here.
> Can you rewrite this as "units.iconSizes.medium + largeSpacing"
>
> Should equate to the same value, but self-documents what it's actually doing and \
> handles a user changing icon sizes in the config file.
Thank you very much for the pointer.
I tried adding the medium size with large spacing, but for some reason it returns \
empty value and the lines got overlapped
F5682153: Screenshot_20180130_005814.png <https://phabricator.kde.org/F5682153>
So I suggest a different method of using "units.gridUnit * 3" since everything else \
is also calculated with this property, it is suitable here I think. Also this returns \
to 54 while earlier the iconSizes.larger returned 48 , this is not harmful because we \
anyways wanted some more space to accommodate longer text.
So changing this to "units.gridUnit * 3" gave a reasonable space and it is \
independent of the icons size now. which gives the below result
F5682158: Screenshot_20180130_011342.png <https://phabricator.kde.org/F5682158>
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D10183
To: kamathraghavendra, davidedmundson, #plasma, broulik, jgrulich
Cc: ngraham, plasma-devel, davidedmundson, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">kamathraghavendra added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10183" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D10183#inline-46875" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">TrafficMonitor.qml:55</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">Semantically it's weird to \
use the size of an icon for a margin, unless you're trying to line up with an \
icon. There's a medium sized icon in the toolbar, which I assume is the intent \
here.</p>
<p style="padding: 0; margin: 8px;">Can you rewrite this as \
"units.iconSizes.medium + largeSpacing"</p>
<p style="padding: 0; margin: 8px;">Should equate to the same value, but \
self-documents what it's actually doing and handles a user changing icon sizes \
in the config file.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">Thank you very much for the pointer.</p>
<p style="padding: 0; margin: 8px;">I tried adding the medium size with large \
spacing, but for some reason it returns empty value and the lines got overlapped<br \
/> <a href="https://phabricator.kde.org/F5682153" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F5682153: \
Screenshot_20180130_005814.png</a></p>
<p style="padding: 0; margin: 8px;">So I suggest a different method of using \
"units.gridUnit * 3" since everything else is also calculated with this \
property, it is suitable here I think. Also this returns to 54 while earlier the \
iconSizes.larger returned 48 , this is not harmful because we anyways wanted some \
more space to accommodate longer text.</p>
<p style="padding: 0; margin: 8px;">So changing this to "units.gridUnit * \
3" gave a reasonable space and it is independent of the icons size now. which \
gives the below result<br /> <a href="https://phabricator.kde.org/F5682158" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F5682158: \
Screenshot_20180130_011342.png</a></p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R116 Plasma Network Management \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10183" \
rel="noreferrer">https://phabricator.kde.org/D10183</a></div></div><br \
/><div><strong>To: </strong>kamathraghavendra, davidedmundson, Plasma, broulik, \
jgrulich<br /><strong>Cc: </strong>ngraham, plasma-devel, davidedmundson, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic