[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10184: Port mediawiki runner to Plasma5/Qt5
From:       Friedrich W. H. Kossebau <noreply () phabricator ! kde ! org>
Date:       2018-01-29 18:15:07
Message-ID: 20180129181507.1.3BC3818F37014538 () phabricator ! kde ! org
[Download RAW message or body]

kossebau created this revision.
kossebau added reviewers: broulik, jriddell, davidedmundson, sebas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Straight initial port of existing logic, with separate plugin metadata files
  for different services. Perhaps could be changed to have just one normal
  plugin, but with a config UI where the user can edit a list of
  mediawiki-running servers and individual trigger words per server.
  Left for another step/developer for now.

TEST PLAN
  A bug in Milou (kde #389611) prevents normal testing for now.
  One can increase that reset timeout to some big value, e.g.
  m_resetTimer.setInterval(3000);
  in the Milou::SourcesModel constructor to work around the bug.
  Then enable the mediawiki plugins you want to test, e.g. the
  Wikipedia one, and enter in KRunner "wiki kde plasma"

REPOSITORY
  R114 Plasma Addons

BRANCH
  portmediawiki

REVISION DETAIL
  https://phabricator.kde.org/D10184

AFFECTED FILES
  runners/CMakeLists.txt
  runners/mediawiki/CMakeLists.txt
  runners/mediawiki/mediawiki.cpp
  runners/mediawiki/mediawiki.h
  runners/mediawiki/mediawikirunner.cpp
  runners/mediawiki/mediawikirunner.h
  runners/mediawiki/plasma-runner-techbase.desktop
  runners/mediawiki/plasma-runner-userbase.desktop
  runners/mediawiki/plasma-runner-wikipedia.desktop
  runners/mediawiki/plasma-runner-wikitravel.desktop

To: kossebau, broulik, jriddell, davidedmundson, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Attachment #3 (unknown)]

<table><tr><td style="">kossebau created this revision.<br />kossebau added \
reviewers: broulik, jriddell, davidedmundson, sebas.<br />Restricted Application \
added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel.<br />kossebau requested review of this revision. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10184" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Straight initial port of existing logic, with separate plugin \
metadata files<br /> for different services. Perhaps could be changed to have just \
one normal<br /> plugin, but with a config UI where the user can edit a list of<br />
mediawiki-running servers and individual trigger words per server.<br />
Left for another step/developer for now.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>A bug in Milou (kde #389611) prevents normal testing for now.<br \
/> One can increase that reset timeout to some big value, e.g.<br />
m_resetTimer.setInterval(3000);<br />
in the Milou::SourcesModel constructor to work around the bug.<br />
Then enable the mediawiki plugins you want to test, e.g. the<br />
Wikipedia one, and enter in KRunner &quot;wiki kde plasma&quot;</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>portmediawiki</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10184" \
rel="noreferrer">https://phabricator.kde.org/D10184</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>runners/CMakeLists.txt<br /> \
runners/mediawiki/CMakeLists.txt<br /> runners/mediawiki/mediawiki.cpp<br />
runners/mediawiki/mediawiki.h<br />
runners/mediawiki/mediawikirunner.cpp<br />
runners/mediawiki/mediawikirunner.h<br />
runners/mediawiki/plasma-runner-techbase.desktop<br />
runners/mediawiki/plasma-runner-userbase.desktop<br />
runners/mediawiki/plasma-runner-wikipedia.desktop<br />
runners/mediawiki/plasma-runner-wikitravel.desktop</div></div></div><br \
/><div><strong>To: </strong>kossebau, broulik, jriddell, davidedmundson, sebas<br \
/><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]