[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10156: Block geometry updates on move resize finish and don't configure xdg shell surfaces while bl
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2018-01-28 9:36:23
Message-ID: 20180128093623.1.69BC889DCF907F38 () phabricator ! kde ! org
[Download RAW message or body]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma, jgrulich.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  We send out too many configure requests when finishing move resize which
  also triggers quick tiling. This change addresses the problem of the too
  many configure requests by making the configure method check whether
  geometry updates are blocked. And to make this work properly for the end
  of finish move resize the complete method is wrapped in a geometry
  update blocker.

TEST PLAN
  Quick tiling test passes, both Wayland and X11 windows are
  quick tiled correctly.

REPOSITORY
  R108 KWin

BRANCH
  block-geometry-update-on-finish-resize-5.12

REVISION DETAIL
  https://phabricator.kde.org/D10156

AFFECTED FILES
  autotests/integration/quick_tiling_test.cpp
  geometry.cpp
  shell_client.cpp
  shell_client.h

To: graesslin, #kwin, #plasma, jgrulich
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin created this revision.<br />graesslin added \
reviewers: KWin, Plasma, jgrulich.<br />Restricted Application added a project: \
KWin.<br />Restricted Application added subscribers: kwin, plasma-devel.<br \
/>graesslin requested review of this revision.<br />Restricted Application edited \
projects, added Plasma; removed KWin. </td><a style="text-decoration: none; padding: \
4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10156" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>We send \
out too many configure requests when finishing move resize which<br /> also triggers \
quick tiling. This change addresses the problem of the too<br /> many configure \
requests by making the configure method check whether<br /> geometry updates are \
blocked. And to make this work properly for the end<br /> of finish move resize the \
complete method is wrapped in a geometry<br /> update blocker.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Quick tiling test passes, both Wayland and \
X11 windows are<br /> quick tiled correctly.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>block-geometry-update-on-finish-resize-5.12</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10156" \
rel="noreferrer">https://phabricator.kde.org/D10156</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>autotests/integration/quick_tiling_test.cpp<br /> \
geometry.cpp<br /> shell_client.cpp<br />
shell_client.h</div></div></div><br /><div><strong>To: </strong>graesslin, KWin, \
Plasma, jgrulich<br /><strong>Cc: </strong>plasma-devel, kwin, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]