[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9070: KDE platform plugin: don't force default stylename on user-specified fonts
From:       René J.V. Bertin <noreply () phabricator ! kde ! org>
Date:       2018-01-27 10:19:37
Message-ID: 20180127101937.1.14BB11576A18C9F0 () phabricator ! kde ! org
[Download RAW message or body]

rjvbb added a comment.


  >   Is this change purely a conversation of what developers use in code to call up \
fonts in their applications?  
  I think so.
  
  >   Or does this also include a discussion where regular users have interfaces that \
allow changes to font naming? Let's say, something like System Settings that would \
allow users to change the naming for system fonts?  
  That already exists as you must have noticed: the Fonts settings panel.
  
  This suggested change removes one source of stylenames being set on fonts beyond \
the user's control. In the original/current code, the table with the default fonts \
(those used before the user makes any customisations) contains stylenames. Later on \
in the code those are set on the fonts being looked up.  The modified version still \
does that, but only if looked-up font already has a stylename set.  
  Concretely this means a better guarantee that the trick of removing the stylename \
part from the font descriptions in settings (rc) files will actually work.  
  The modification should be transparent to anyone who does NOT remove stylenames and \
is thus the least invasive change. I still think the platform theme plugin should \
never have started calling setStyleName in the first place, and certainly not for \
default fonts that are perfectly described by the PANOSE system and thus don't need a \
stylename.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: abetts, anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">rjvbb added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9070" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><div class="remarkup-code-block" style="margin: 12px 0;" \
data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Is this \
change purely a conversation of what developers use in code to call up fonts in their \
applications?</pre></div></blockquote>

<p>I think so.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><div \
class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Or does this also include a \
discussion where regular users have interfaces that allow changes to font naming? \
Let&#039;s say, something like System Settings that would allow users to change the \
naming for system fonts?</pre></div></blockquote>

<p>That already exists as you must have noticed: the Fonts settings panel.</p>

<p>This suggested change removes one source of stylenames being set on fonts beyond \
the user&#039;s control. In the original/current code, the table with the default \
fonts (those used before the user makes any customisations) contains stylenames. \
Later on in the code those are set on the fonts being looked up.<br /> The modified \
version still does that, but only if looked-up font already has a stylename set.</p>

<p>Concretely this means a better guarantee that the trick of removing the stylename \
part from the font descriptions in settings (rc) files will actually work.</p>

<p>The modification should be transparent to anyone who does NOT remove stylenames \
and is thus the least invasive change. I still think the platform theme plugin should \
never have started calling setStyleName in the first place, and certainly not for \
default fonts that are perfectly described by the PANOSE system and thus don&#039;t \
need a stylename.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R135 \
Integration for Qt applications in Plasma</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9070" \
rel="noreferrer">https://phabricator.kde.org/D9070</a></div></div><br \
/><div><strong>To: </strong>rjvbb, Frameworks, davidedmundson, graesslin, cfeck, \
dfaure<br /><strong>Cc: </strong>abetts, anthonyfieroni, ngraham, cfeck, fvogt, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, \
apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]