[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10066: Add touchpad shortcuts to the whitelist
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2018-01-24 5:28:01
Message-ID: 20180124052801.1.6A3C80290E9ACBE3 () phabricator ! kde ! org
[Download RAW message or body]

graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> globalaccel.cpp:59
> +    )},
> +    {QStringLiteral("/component/kcm_touchpad"), QRegularExpression(
> +        QStringLiteral("Toggle Touchpad|Enable Touchpad|Disable Touchpad")

This won't work on Wayland as there KWin holds the shortcut.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D10066

To: dos, #plasma, graesslin
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin requested changes to this revision.<br />graesslin \
added inline comments.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10066" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10066#inline-46210" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">globalaccel.cpp:59</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">    <span class="p">)},</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="p">{</span><span class="n">QStringLiteral</span><span class="p">(</span><span \
style="color: #766510">&quot;/component/kcm_touchpad&quot;</span><span \
class="p">),</span> <span class="n">QRegularExpression</span><span class="p">(</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">        <span class="n">QStringLiteral</span><span class="p">(</span><span \
style="color: #766510">&quot;Toggle Touchpad|Enable Touchpad|Disable \
Touchpad&quot;</span><span class="p">)</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This \
won&#039;t work on Wayland as there KWin holds the \
shortcut.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R133 KScreenLocker</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10066" \
rel="noreferrer">https://phabricator.kde.org/D10066</a></div></div><br \
/><div><strong>To: </strong>dos, Plasma, graesslin<br /><strong>Cc: \
</strong>graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]